Skip to content

[codex] fix golangci-lint v2 config#24

Merged
Miss-you merged 3 commits into
mainfrom
codex/fix-golangci-lint-v2
Apr 15, 2026
Merged

[codex] fix golangci-lint v2 config#24
Miss-you merged 3 commits into
mainfrom
codex/fix-golangci-lint-v2

Conversation

@Miss-you

Copy link
Copy Markdown
Owner

Summary

  • Migrate .golangci.yml to golangci-lint v2 format so local golangci-lint v2.8.0 can load it.
  • Align the Makefile and CI lint versions on v2.8.0.
  • Add the AI-agent-friendly CLI UX implementation plan under docs/plans.

Root Cause

The repository config was still in golangci-lint v1 format while local tooling was golangci-lint v2.8.0. v2 rejects configs without a version field, causing make lint to fail before linting code.

Validation

  • git diff --cached --check
  • staged secret scan: no matches
  • golangci-lint config verify
  • make lint (0 issues.)
  • make vet
  • make build
  • make test

Scope Notes

  • The unrelated untracked OpenSpec change under openspec/changes/claude-internal-and-subagents-support/ is intentionally not included.

Copilot AI review requested due to automatic review settings April 15, 2026 05:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s golangci-lint configuration and CI setup to be compatible with golangci-lint v2.x, while adding a new internal implementation plan document for CLI UX improvements.

Changes:

  • Migrates .golangci.yml to golangci-lint v2 config structure (including formatter configuration).
  • Pins CI lint action to v2.8.0 and updates the Makefile’s lint version variable.
  • Adds an AI-agent-friendly CLI UX improvements implementation plan under docs/plans.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
docs/plans/2026-04-15-ai-agent-friendly-cli-ux-improvements.md Adds a structured implementation plan for CLI UX improvements and acceptance criteria.
Makefile Updates the declared golangci-lint version variable to v2.8.0.
.golangci.yml Migrates lint/format config to golangci-lint v2 format with exclusions and formatter settings.
.github/workflows/ci.yml Updates golangci-lint GitHub Action to run v2.8.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile Outdated
Comment thread .golangci.yml
Comment thread .golangci.yml
@Miss-you
Miss-you merged commit 5325d18 into main Apr 15, 2026
7 checks passed
@Miss-you
Miss-you deleted the codex/fix-golangci-lint-v2 branch April 15, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants