fix: support legacy Cursor CSV exports#16
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Cursor CSV usage parser to accept legacy exports that omit the Kind column, while expanding test coverage for additional parsing edge-cases and deterministic session ordering across multiple files.
Changes:
- Relax Cursor CSV header validation by no longer requiring the
Kindcolumn. - Add parser tests for legacy exports (no
Kind), blank token cells, RFC3339 timestamp variants, and deterministic multi-file collection with invalid-file skipping.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
provider/cursor/parser.go |
Makes Kind optional by removing it from the required header set. |
provider/cursor/parser_test.go |
Adds coverage for legacy exports, token blank handling, timestamp formats, and deterministic ordering while skipping invalid CSVs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kindcolumn while keeping the existing token-field mapping intactYOU-9Validation
env GOCACHE=/tmp/codetok-gocache GOMODCACHE=/tmp/codetok-gomodcache go test ./provider/cursor -count=1env GOCACHE=/tmp/codetok-gocache GOMODCACHE=/tmp/codetok-gomodcache make fmtenv GOCACHE=/tmp/codetok-gocache GOMODCACHE=/tmp/codetok-gomodcache make vetenv GOCACHE=/tmp/codetok-gocache GOMODCACHE=/tmp/codetok-gomodcache make testenv GOCACHE=/tmp/codetok-gocache GOMODCACHE=/tmp/codetok-gomodcache make build./bin/codetok daily --all --cursor-dir /Users/apple/Documents/Github/symphony-workspaces/YOU-9/e2e/testdata/cursor --claude-dir <empty-dir> --codex-dir <empty-dir> --kimi-dir <empty-dir>env GOCACHE=/tmp/codetok-gocache GOMODCACHE=/tmp/codetok-gomodcache make lint(repo Makefile skipped becausegolangci-lintis not installed in this environment)Notes