Skip to content

YOU-5: add README validation workflow note#12

Merged
Miss-you merged 1 commit into
mainfrom
sgsnowfly1993/you-5-add-hello-world-pr-for-this-project
Mar 12, 2026
Merged

YOU-5: add README validation workflow note#12
Miss-you merged 1 commit into
mainfrom
sgsnowfly1993/you-5-add-hello-world-pr-for-this-project

Conversation

@Miss-you

Copy link
Copy Markdown
Owner

Summary

  • add a README validation workflow section for smoke-test PRs
  • document the repo validation commands and the required rebuild before manual CLI verification
  • add a reproducible built-binary smoke test using the bundled fixture data

Validation

  • env GOCACHE=/tmp/codetok-gocache GOMODCACHE=/tmp/codetok-gomodcache make fmt
  • env GOCACHE=/tmp/codetok-gocache GOMODCACHE=/tmp/codetok-gomodcache make vet
  • env GOCACHE=/tmp/codetok-gocache GOMODCACHE=/tmp/codetok-gomodcache make test
  • env GOCACHE=/tmp/codetok-gocache GOMODCACHE=/tmp/codetok-gomodcache make build
  • ./bin/codetok daily --all --kimi-dir "$(pwd)/e2e/testdata/sessions" --claude-dir /tmp/codetok-empty.YCzoLf --codex-dir /tmp/codetok-empty.YCzoLf

Notes

  • make lint reports the documented skip because golangci-lint is not installed in this environment.
  • Refs YOU-5

Copilot AI review requested due to automatic review settings March 11, 2026 17:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a documented “Validation Workflow” section to the README to standardize pre-PR checks and provide a repeatable smoke-test command using the repository’s bundled fixtures.

Changes:

  • Documented a recommended local validation sequence (make fmt, vet, test, lint, build) to run before opening a PR.
  • Added a fixture-based smoke-test example for ./bin/codetok daily --all that avoids using real user session logs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Miss-you
Miss-you merged commit 9e56d43 into main Mar 12, 2026
11 checks passed
@Miss-you
Miss-you deleted the sgsnowfly1993/you-5-add-hello-world-pr-for-this-project branch March 12, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants