Fix 9pfs hostPath mounts and add 9pfs tests #862
Conversation
hostPath was only working for the host paths that are mounted inside the virtlet container.
ivan4th
force-pushed
the
ivan4th/9pfs-tests
branch
from
99314fa to
73535f3
Compare
ivan4th
changed the title
jellonek
left a comment
jellonek
left a comment
There was a problem hiding this comment.
One question and rest lgtm.
Reviewed 52 of 52 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @ivan4th)
tests/e2e/framework/controller.go, line 395 at r1 (raw file):
} pod := generatePodSpec(name, image, opts) fmt.Printf("POD:\n%s\n", utils.ToJSON(pod))
That's the only place where Printf is used in whole file. Are you sure that it should be always printed there, or this was only needed during development time?
It doesn't support CirrOS at this moment because of lack of 9p filesystem support there.
ivan4th
force-pushed
the
ivan4th/9pfs-tests
branch
from
73535f3 to
8eb5915
Compare
ivan4th
left a comment
ivan4th
left a comment
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @jellonek)
tests/e2e/framework/controller.go, line 395 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
That's the only place where Printf is used in whole file. Are you sure that it should be always printed there, or this was only needed during development time?
Thanks, fixed!
jellonek
left a comment
jellonek
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! 1 of 1 approvals obtained
hostPathproblem (was unable to mount host paths not visible in thevirtletcontainer)This change is