Do not remove container if start container failed #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellonek
approved these changes
Jan 31, 2019
Contributor
jellonek
left a comment
jellonek
left a comment
There was a problem hiding this comment.
That was very old part done before we even had beginnings of garbage collection so in fact these remains were now unnecessary.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not a good option to remove container if start container failed. The comments:
// FIXME: we do this here because kubelet may attempt new `CreateContainer()` // calls for this VM after failed `StartContainer()` without first removing it.Even kubelet may attempt new
CreateContainer(), the virtlet will do nothing as the container has already been in db: https://github.com/Mirantis/virtlet/blob/master/pkg/manager/runtime.go#L305To remove container, the domain and VM will be removed too, it will impact running VMs, all data of running VM may be lost. For example, if the disk is full, the VM will get into paused state, and you cannot start the domain, but we should not remove the VM to workaround the problem.
This change is