Reviewable status: 0 of 1 approvals obtained (waiting on @jellonek)

pkg/libvirttools/cpusets.go, line 41 at r1 (raw file):

// setting environment variable for vmwrapper with info about to which cpuset it should
// pin itself
func (v *VirtualizationTool) UpdateCpusetsInContainerDefinition(containerID, cpusets string) error {

// UpdateCpusetsInContainerDefinition updates libvirt domain definition for the VM
// setting the environment variable which is used by vmwrapper to pin to the specified cpuset

pkg/libvirttools/cpusets.go, line 114 at r1 (raw file):

}

func checkIfItsPidOfContainerEmulator(pid, containerID string) (bool, error) {

isEmulatorPid

also, perhaps this can be written as "TODO" for now, but this kind of check is rather weak IMO.

as discussed, should be replaced with reading /run/libvirt/qemu/DOMAIN_NAME.pid in a followup

pkg/libvirttools/cpusets.go, line 126 at r1 (raw file):

	}

	searchedTerm := "virtlet-" + containerID[:12]

searchTerm

Reviewed 9 of 11 files at r1, 2 of 2 files at r2.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @jellonek)