Skip to content

Conversation

@jellonek
Copy link
Contributor Author

Tests are failing probably because of current failure in k-d-c master (we are waiting for kubernetes-retired/kubeadm-dind-cluster#258 - will restart jobs after merge of it).
Tests on local machine went fine.

Copy link
Contributor

@ivan4th ivan4th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, 1 of 1 files at r2.
Reviewable status: 0 of 1 approvals obtained

Copy link
Contributor

@ivan4th ivan4th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@ivan4th ivan4th merged commit 9b43b4d into master Nov 27, 2018
@ivan4th ivan4th deleted the jell/libvirt branch November 27, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants