Fix handling of dhcp classless routes #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are any classless routes passed from the DHCP server, some DHCP client implementations ignore the router setting. In order to work around this issue, we use the classless routes option instead of the router option in case if there are any options except for the default one.
jellonek
approved these changes
Oct 17, 2018
Contributor
jellonek
left a comment
jellonek
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 2 approvals obtained
lukaszo
approved these changes
Oct 18, 2018
Contributor
lukaszo
left a comment
lukaszo
left a comment
There was a problem hiding this comment.
Reviewable status: 1 of 2 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are any classless routes passed from the DHCP server, some
DHCP client implementations ignore the router setting. In order to work
around this issue, we use the classless routes option instead of the
router option in case if there are any options except for the default
one.
This was breaking flannel e2e test.
This change is