Update block PV & persistent rootfs docs+examples #772
Conversation
jellonek
left a comment
jellonek
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status: 0 of 2 approvals obtained (waiting on @ivan4th)
examples/cirros-vm-persistent-rootfs-rbd.yaml, line 65 at r1 (raw file):
containers: - name: cirros-vm #image: virtlet.cloud/cirros
That can be removed.
examples/README.md, line 86 at r1 (raw file):
for testing, you can use this command to start the cluster with `BlockVolume` and Ceph support:
Maybe ```console ?
Same for rest of below code blocks. console or bash (they are a bit different)?
examples/README.md, line 221 at r1 (raw file):
demonstrates the use of persistent root filesystem. The most important part is the `volumeDevices` section in the pod's container definition:
jellonek
left a comment
jellonek
left a comment
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 2 approvals obtained (waiting on @ivan4th)
examples/README.md, line 221 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
</blockquote></details> idk why reviewable messed that up, but there was info about ```yaml (yaml type for code block, if it again will try to chop it down) <!-- Sent from Reviewable.io -->
ivan4th
force-pushed
the
ivan4th/persistent-rootfs-docs
branch
from
82a3b77 to
e60dfb3
Compare
ivan4th
left a comment
ivan4th
left a comment
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 2 approvals obtained (waiting on @jellonek and @ivan4th)
examples/cirros-vm-persistent-rootfs-rbd.yaml, line 65 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
That can be removed.
Done.
examples/README.md, line 86 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Maybe ```console ?
Same for rest of below code blocks. console or bash (they are a bit different)?
Fixed. console is for console interaction snippets (with the prompt), bash is for shell snippets (without the prompt). Most snippets are bash for easier copy-paste.
ivan4th
force-pushed
the
ivan4th/persistent-rootfs-docs
branch
from
e60dfb3 to
c54a172
Compare
jellonek
left a comment
jellonek
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, 1 of 1 files at r3.
Reviewable status: 1 change requests, 0 of 2 approvals obtained
pigmej
left a comment
pigmej
left a comment
There was a problem hiding this comment.
Reviewed 4 of 6 files at r1, 1 of 2 files at r2, 1 of 1 files at r3.
Reviewable status: 1 of 2 approvals obtained
[ci skip]
This change is