Reviewed 3 of 3 files at r1, 3 of 3 files at r2.
Reviewable status: 0 of 2 LGTMs obtained

docs/resource_managment.md, line 6 at r2 (raw file):

By default, libvirt runs QEMU with a CPU model that doesn't support nested virtualization. It's possible to change this behavior by using `VirtletCPUModel: host-model` annotation in the pod definition. You can also use `cpuModel` value in Virtlet config to override the value globally for the cluster or for a particular subset of nodes.

If you are familiar with the cpu part in libvirt domain definition, you can use `VirtletLibvirtCPUSetting` annotation, the value is directly passed to libvirt after translating form yaml style. it is more flexible.

"It is more flexible than usage of VirtletCPUModel as it allows to provide more detailed configuration."

Reviewable status: 0 of 2 LGTMs obtained

docs/resource_managment.md, line 6 at r3 (raw file):

By default, libvirt runs QEMU with a CPU model that doesn't support nested virtualization. It's possible to change this behavior by using `VirtletCPUModel: host-model` annotation in the pod definition. You can also use `cpuModel` value in Virtlet config to override the value globally for the cluster or for a particular subset of nodes.

If you are familiar with the cpu part in libvirt domain definition, you can use `VirtletLibvirtCPUSetting` annotation, the value is directly passed to libvirt after translating form yaml style. It is more flexible than usage of VirtletCPUModel as it allows to provide more detailed configuration.

Please enclose VirtletCPUModel with backticks as you did in VirtletLibvirtCPUSettings case.

Reviewable status: 0 of 2 LGTMs obtained

docs/resource_managment.md, line 6 at r3 (raw file):

By default, libvirt runs QEMU with a CPU model that doesn't support nested virtualization. It's possible to change this behavior by using `VirtletCPUModel: host-model` annotation in the pod definition. You can also use `cpuModel` value in Virtlet config to override the value globally for the cluster or for a particular subset of nodes.

If you are familiar with the cpu part in libvirt domain definition, you can use `VirtletLibvirtCPUSetting` annotation, the value is directly passed to libvirt after translating form yaml style. It is more flexible than usage of VirtletCPUModel as it allows to provide more detailed configuration.

Btw. "after translating form yaml style" -> "after reading it from yaml string".

Reviewed 1 of 1 files at r4.
Reviewable status: 0 of 2 LGTMs obtained, and 1 stale

Reviewed 3 of 3 files at r1, 2 of 3 files at r2, 1 of 1 files at r4.
Reviewable status: 1 of 2 LGTMs obtained

Reviewable status: 1 of 2 LGTMs obtained, and 1 stale