Virtlet diagnostics #712
Virtlet diagnostics #712
Conversation
Make pools listable. Add XML() methods to pools and volumes.
This command patches sonobuoy-generated yaml to include the Virtlet plugin.
It's functionality is now covered by `virtletctl diag dump` in a safer manner.
ivan4th
force-pushed
the
ivan4th/diag
branch
3 times, most recently
from
816b8cd to
38eed99
Compare
|
The PR is ready for review. |
jellonek
left a comment
jellonek
left a comment
There was a problem hiding this comment.
Please remove from PR changes in docs which are only changing timestamp.
Reviewed 43 of 50 files at r1, 1 of 1 files at r2.
Reviewable status: 0 of 2 LGTMs obtained
docs/diagnostics.md, line 6 at r2 (raw file):
[virtletctl diag](virtletctl/virtletctl_diag.md) commands that can help with troubleshooting. The diagnostics can be invoked either directly or buy means of a
s/buy/by/
pkg/diag/diag.go, line 109 at r2 (raw file):
switch { case dr.Name == "": return errors.New("Result name is not set")
error message should started from lower case character.
pkg/diag/diag.go, line 114 at r2 (raw file):
return nil case !dr.IsDir && len(dr.Children) != 0: return errors.New("Result can't contain both Data and Children")
same as above
ivan4th
left a comment
ivan4th
left a comment
There was a problem hiding this comment.
As of the timestamps, I re-generated docs several times in different commits. I'm not sure filtering each commit or adding another one on top of them to revert the changes is worth it ;(
Reviewable status: 0 of 2 LGTMs obtained
docs/diagnostics.md, line 6 at r2 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
s/buy/by/
Done.
pkg/diag/diag.go, line 109 at r2 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
error message should started from lower case character.
This is a message that reports a malformed data structure. The structure is called Result (starting from capital letter). This error shouldn't happen under normal circumstances, so it's kind of "internal"
pkg/diag/diag.go, line 114 at r2 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
same as above
same, capitalized Result is the name of the structure
jellonek
left a comment
jellonek
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 2 LGTMs obtained, and 1 stale
pkg/diag/diag.go, line 109 at r2 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
This is a message that reports a malformed data structure. The structure is called
Result(starting from capital letter). This error shouldn't happen under normal circumstances, so it's kind of "internal"
Ah, right. My mistake.
lukaszo
left a comment
lukaszo
left a comment
There was a problem hiding this comment.
Reviewable status: 1 of 2 LGTMs obtained, and 1 stale
This adds a possibility to retrieve Virtlet diagnostics information using
sonobuoyorvirtletctl. When using sonobuoy, a plugin is added that uses virtlet image to invokevirtletctl diag.virtletctl dumpmetadatacommand is removed as its output is now available as partof what
virtletctl diag dumpproduces, but it's obtained in a safer manner.virtlet --diag(grabbing diagnostics info from within the Virtlet pod)virtletctl diag dumpthat retrieves diagnostics info from each virtlet pod (--jsonto get raw json w/o unpacking)virtletctl diag unpackthat unpacks Virtlet diagnostics from JSON filevirtletctl diag sonobuoythat patches sonobuoy yaml to inject Virtlet pluginvirtletctl diag dump[convenience]virtletctl dumpmetadataThis change is