Display record count in UI#638
Merged
nateberkopec merged 4 commits intoMiniProfiler:masterfrom Feb 5, 2025
Merged
Conversation
coalest
force-pushed
the
show-record-count-in-ui
branch
from
7a67352 to
23f84ee
Compare
Collaborator
Author
|
Not sure whether to return 0 or nothing when a query doesn't instantiate any Active Record instances. Thoughts? |
Collaborator
|
Definitely nothing, as people who don't use ActiveRecord will be annoyed at all the 0 spam |
nateberkopec
requested changes
Feb 4, 2025
Collaborator
nateberkopec
left a comment
nateberkopec
left a comment
There was a problem hiding this comment.
Should display nothing in case of 0
Collaborator
Author
|
Fixed in 552105f to not show anything if no AR records were instantiated. Updated screenshot above to match changes. |
Collaborator
|
Thanks @coalest! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #596
Screenshot
Updated to show nothing when no AR records were instantiated:
