Truncate long profiler name in profiler popup#634
Merged
Conversation
3b9dbc4 to
2b72d96
Compare
Member
|
look at the truncating on the left (it leaves left and right bounds) ... can you match the algorithm, I would say we have a tiny bit more room though so you can adjust to suite. |
2b72d96 to
cc06a99
Compare
cc06a99 to
395da37
Compare
Collaborator
Author
|
@SamSaffron I've updated the solution to be CSS based instead. |
SamSaffron
approved these changes
Feb 3, 2025
Member
|
I am OK with this but /some/long/...../some/other would be nicer if possible. |
Collaborator
Author
We wouldn't be able to rely on a CSS solution in this case. This is the current heuristic which we use for the badge |
Member
|
yeah this would require js to be dynamic. I guess this is way better than what we have now so we just go with it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshot
Before
After