Skip to content

Fix Rack::File is deprecated and will be removed in Rack 3.1#604

Merged
nateberkopec merged 1 commit intoMiniProfiler:masterfrom
taketo1113:fix-rack-files
Jan 2, 2024
Merged

Fix Rack::File is deprecated and will be removed in Rack 3.1#604
nateberkopec merged 1 commit intoMiniProfiler:masterfrom
taketo1113:fix-rack-files

Conversation

@taketo1113
Copy link
Contributor

It fixed #600 with approache of No.2

I guess there are two approaches to how to resolve this:
2. Keep the minimum compatible Rack version at >= 1.2.0 and write a compatibility check/layer in this gem instead.

It added to use Rack::Files for rack v2.1.0+.
if rack version is less v2.1.0, it remains to use Rack::File.

@nateberkopec nateberkopec merged commit fd2d5d3 into MiniProfiler:master Jan 2, 2024
@taketo1113 taketo1113 deleted the fix-rack-files branch January 2, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation warning with Rack >= 3.0.0 - Rack::File is deprecated and will be removed in Rack 3.1

2 participants