Add option to ignore garbage collection frames with flamegraphs#599
Merged
nateberkopec merged 2 commits intoMiniProfiler:masterfrom Dec 7, 2023
Merged
Conversation
Collaborator
|
Something I've wanted for a long time! I know I just did a release but this is too useful to let set on main for a long time. I'll just do another minor version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #514
This adds a configuration option to ignore garbage collection via the
ignore_gcoption in StackProf. Users can override this configuration on a per-request basis via theflamegraph_ignore_gcquery param.I tested this change out on a separate app using this branch and confirmed garbage collection frames were visible by default, and hidden after setting
Rack::MiniProfiler.config.flamegraph_ignore_gc = trueor using the query param.