Fix: account for vertical position bottom in placement of popup#581
Merged
nateberkopec merged 1 commit intoMiniProfiler:masterfrom Dec 6, 2023
yannickm95:master
Merged
Fix: account for vertical position bottom in placement of popup#581nateberkopec merged 1 commit intoMiniProfiler:masterfrom yannickm95:master
nateberkopec merged 1 commit intoMiniProfiler:masterfrom
yannickm95:master
Conversation
use parent height to determine bottom style property for popup
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use parent height to determine bottom style property for the popup as we start from the bottom to position and not the top. Also, take button height (
21px) into account so it's positioned at the bottom.See #580 for more information.