Skip to content

Add titles to middleware pages#552

Merged
nateberkopec merged 1 commit intoMiniProfiler:masterfrom
gmcgibbon:html_titles
Apr 5, 2023
Merged

Add titles to middleware pages#552
nateberkopec merged 1 commit intoMiniProfiler:masterfrom
gmcgibbon:html_titles

Conversation

@gmcgibbon
Copy link
Contributor

Right now the pages you visit that route to the middleware don't have HTML titles or valid markup. This fixes that.

Right now the pages you visit that route to the middleware don't have
HTML titles or valid markup. This fixes that.
@codecov-commenter
Copy link

Codecov Report

Merging #552 (55e2a34) into master (edbcad3) will increase coverage by 0.78%.
The diff coverage is 100.00%.

❗ Current head 55e2a34 differs from pull request most recent head af5d27a. Consider uploading reports for the commit af5d27a to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   87.39%   88.17%   +0.78%     
==========================================
  Files          18       18              
  Lines        1269     1269              
==========================================
+ Hits         1109     1119      +10     
+ Misses        160      150      -10     
Impacted Files Coverage Δ
lib/mini_profiler/profiler.rb 85.41% <100.00%> (+1.90%) ⬆️
lib/mini_profiler/client_settings.rb 95.58% <0.00%> (+1.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nateberkopec
Copy link
Collaborator

Rebase and LGTM 👍

@nateberkopec nateberkopec merged commit c13e925 into MiniProfiler:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants