Deprecate rack_profiler:install in favour of rack_mini_profiler:install#550
Merged
SamSaffron merged 1 commit intoMiniProfiler:masterfrom Mar 28, 2023
Merged
Conversation
The gem's name and install generator should be the same.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #550 +/- ##
=======================================
Coverage 87.39% 87.39%
=======================================
Files 18 18
Lines 1269 1269
=======================================
Hits 1109 1109
Misses 160 160 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nateberkopec
approved these changes
Mar 28, 2023
Member
|
I think the reason I was holding off on merging stuff was cause our test suite is not passing, looks unrelated though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gem's name and install generator should be the same.
This deprecates the current generator in favour of a more appropriately named one. It also updates copy on the initializer comments and usage clarifying what it is doing and when to use an initializer. Behaviour is changed for the install generator to always generate a
rack_mini_profiler.rbinitializer instead, but I think that's acceptable if we want to rename the generator.