fix(browser): evict stuck pages on cached connections too#2
Merged
Conversation
…loses openclaw#104) Playwright's connectOverCDP() attaches to ALL open pages during initialization. If any page's renderer is stuck (e.g. TradingView with heavy JS), the entire connection hangs indefinitely. Add a pre-connection health check that probes each page via raw CDP Runtime.evaluate("1") and closes unresponsive pages before connectOverCDP() runs.
The eviction only ran during fresh connectOverCDP() calls. When a cached
Playwright connection was reused, stuck pages (e.g. TradingView with
blocked renderer) would cause page-level operations to hang instead.
Now evictStuckPagesViaCdp() runs before returning the cached connection,
closing any pages whose Runtime.evaluate("1") doesn't respond within 3s.
Playwright auto-removes closed pages via Target.targetDestroyed events.
Milofax
added a commit
that referenced
this pull request
Feb 18, 2026
* fix(browser): evict stuck browser pages before Playwright connection (Closes openclaw#104) Playwright's connectOverCDP() attaches to ALL open pages during initialization. If any page's renderer is stuck (e.g. TradingView with heavy JS), the entire connection hangs indefinitely. Add a pre-connection health check that probes each page via raw CDP Runtime.evaluate("1") and closes unresponsive pages before connectOverCDP() runs. * fix(browser): run stuck page eviction on cached connections too The eviction only ran during fresh connectOverCDP() calls. When a cached Playwright connection was reused, stuck pages (e.g. TradingView with blocked renderer) would cause page-level operations to hang instead. Now evictStuckPagesViaCdp() runs before returning the cached connection, closing any pages whose Runtime.evaluate("1") doesn't respond within 3s. Playwright auto-removes closed pages via Target.targetDestroyed events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #1 — the eviction only ran during fresh
connectOverCDP()calls. When the cached Playwright connection was reused, stuck pages still caused hangs.Now
evictStuckPagesViaCdp()also runs before returning a cached connection.Verified on Mac Mini:
Runtime.evaluate("1")never responds)connectOverCDP()succeeds in 7msCloses Milofax/marakanda-infrastructure#104