Replace "System.Drawing" with "SkiaSharp" in all scripts.#24
Merged
Miepee merged 4 commits intoMiepee:skiasharpfrom Jun 2, 2024
Merged
Replace "System.Drawing" with "SkiaSharp" in all scripts.#24Miepee merged 4 commits intoMiepee:skiasharpfrom
Miepee merged 4 commits intoMiepee:skiasharpfrom
Conversation
|
Download the artifacts for this pull request here: GUI:
CLI: |
VladiStep
force-pushed
the
skiasharpScripts
branch
from
6e4faf5 to
2b41ead
Compare
Owner
|
TODO: test all of the scripts |
Miepee
reviewed
Jan 18, 2024
| Bitmap img = new Bitmap(path); | ||
| tileset.Texture.ReplaceTexture((Image)img); | ||
| } | ||
| tileset.Texture.ReplaceTexture(SKBitmap.Decode(path), true); |
Owner
There was a problem hiding this comment.
what would happen if the file does not exist? does it just do a silent warning?
| MaxOneAxis, | ||
| } | ||
|
|
||
| public struct Rect |
Owner
There was a problem hiding this comment.
this is like the fourth time that this is created in a script. It may be worth it to clarify that somewhere in the textureworker instead?
Owner
|
can you add a top comment to "FontEditor.csx" and "ExportFontData.csx" to say something like "These are Windows only. Refactor these in the future when we have a Cross-platform UI"? |
Miepee
added a commit
that referenced
this pull request
Jun 2, 2024
* Restore WIP script changes * Finish removing/replacing of "System.Drawing" in all scripts (not tested) * Update MergeImages.csx * Update ImportMasks.csx --------- Co-authored-by: Miepee <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It should close this issue.
Caveats
"FontEditor.csx" and "ExportFontData.csx" are heavily using "System.Windows.Forms" (therefore "System.Drawing"), so I skipped them for now.
Notes
I only tested "ImportFontData.csx" and "ImportGraphics.csx".