bugfix: vol80 could not be set / add maxvolcardids#633
Merged
MiczFlor merged 2 commits intoNov 20, 2019
Conversation
add new maxvolume cardids
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up pull request for this one:
#616
While testing these changes I found out, that MAXVOL80 didn't work in the last version.
Additionally I found out that VOL80 was not fully implemented until now.
So I added MAXVOL80 and VOL80 to rfid_trigger.sh
@MiczFlor : Please remove the changes of the last pull request from the develop branch. I tested this pullrequest with Raspbian buster and without Spotify. All max values could be set correctly. VOL80 works, too. So I think you can merge these changes directly to the master branch.