Merged
Conversation
|
@BillyONeal : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Contributor
|
Learn Build status updates of commit ab15c52: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
vicroms
requested changes
Mar 14, 2025
Collaborator
vicroms
left a comment
vicroms
left a comment
There was a problem hiding this comment.
Minor nit, but LGTM.
I would like to see an example of this feature being used in the maintainer guide as a tip to disable optional dependencies.
dg0yt
suggested changes
Mar 15, 2025
vicroms
reviewed
Mar 17, 2025
Co-authored-by: Kai Pastor <[email protected]>
prmerger-automator
bot
added
review-team-triage
and removed
qualifies-for-auto-merge
labels
vicroms
approved these changes
Apr 7, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Author
|
@vicroms Looks like that link is broken |
dg0yt
reviewed
Apr 7, 2025
Co-authored-by: Kai Pastor <[email protected]>
Contributor
|
Learn Build status updates of commit c020edd: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from microsoft/vcpkg#27950