Skip to content

Fixes #9136 - Fix module specification hashtable docs#9138

Merged
sdwheeler merged 2 commits intoMicrosoftDocs:mainfrom
sdwheeler:sdw-i9136
Aug 18, 2022
Merged

Fixes #9136 - Fix module specification hashtable docs#9138
sdwheeler merged 2 commits intoMicrosoftDocs:mainfrom
sdwheeler:sdw-i9136

Conversation

@sdwheeler
Copy link
Copy Markdown
Collaborator

@sdwheeler sdwheeler commented Aug 18, 2022 •
edited by azure-boards bot
Loading

PR Summary

Fixes AB#5080 - Fixes #9136 - Fix module specification hashtable docs

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

@opbld30

This comment was marked as outdated.

Sign in to view
@opbld31

This comment was marked as outdated.

Sign in to view
michaeltlombardi
michaeltlombardi previously approved these changes Aug 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@michaeltlombardi michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me! I was reminded that this applies and likely needs to be updated across the cmdlet reference docs that use the ModuleSpecification type as valid input. Quick check shows that this includes:

  • The FullyQualifiedModule parameter for Get-Command, , Save-Help, Update-Help, Export-PSSession, and Import-PSSession
  • The FullyQualifiedName parameter for Get-Module, Import-Module, and Remove-Module

We could address those here or in another issue/PR - approving this PR in case we decide to do the latter.

@michaeltlombardi
(GH-9138) Update ModuleSpecification params
51b4f23 
This commit updates the parameter documentation for the cmdlets
that have the ModuleSpecification type to use the updated and
corrected language.
@opbld31
Copy link
Copy Markdown

opbld31 commented Aug 18, 2022

Docs Build status updates of commit 51b4f23:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/About/about_Requires.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_Using.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/Get-Command.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/Get-Module.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/Import-Module.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/Remove-Module.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/Save-Help.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/Update-Help.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Utility/Export-PSSession.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Utility/Import-PSSession.md ✅Succeeded View (powershell-5.1)
reference/7.0/Microsoft.PowerShell.Core/About/about_Requires.md ✅Succeeded View (powershell-7)
reference/7.0/Microsoft.PowerShell.Core/About/about_Using.md ✅Succeeded View (powershell-7)
reference/7.0/Microsoft.PowerShell.Core/Get-Command.md ✅Succeeded View (powershell-7)
reference/7.0/Microsoft.PowerShell.Core/Get-Module.md ✅Succeeded View (powershell-7)
reference/7.0/Microsoft.PowerShell.Core/Import-Module.md ✅Succeeded View (powershell-7)
reference/7.0/Microsoft.PowerShell.Core/Remove-Module.md ✅Succeeded View (powershell-7)
reference/7.0/Microsoft.PowerShell.Core/Save-Help.md ✅Succeeded View (powershell-7)
reference/7.0/Microsoft.PowerShell.Core/Update-Help.md ✅Succeeded View (powershell-7)
reference/7.0/Microsoft.PowerShell.Utility/Export-PSSession.md ✅Succeeded View (powershell-7)
reference/7.0/Microsoft.PowerShell.Utility/Import-PSSession.md ✅Succeeded View (powershell-7)
reference/7.2/Microsoft.PowerShell.Core/About/about_Requires.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_Using.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/Get-Command.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/Get-Module.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/Import-Module.md ✅Succeeded View (powershell-7.2)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@sdwheeler sdwheeler merged commit 1ea1024 into MicrosoftDocs:main Aug 18, 2022
@sdwheeler sdwheeler deleted the sdw-i9136 branch August 18, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaeltlombardi michaeltlombardi michaeltlombardi left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Module specification hashtable information is wrong

4 participants

@sdwheeler @opbld30 @opbld31 @michaeltlombardi