Add more examples to about_Operators by yecril71pl · Pull Request #8280 · MicrosoftDocs/PowerShell-Docs

yecril71pl · 2021-10-30T19:53:17Z

PR Summary

I find it frustrating to see a cast and having to evaluate its value, so I decided to provide explicit results.
Also, fun with hexadecimal strings (℅ BaseNumberConverter).

PR Context

Select the area of the Table of Contents containing the documents being changed.

Conceptual content

Cmdlet reference & about_ topics

Preview content
Version 7.1 content
Version 7.0 content
Version 5.1 content

PR Checklist

I have read the contributors guide and followed the style and process guidelines
PR has a meaningful title
PR is targeted at the staging branch
All relevant versions updated
Includes content related to issues and PRs - see Closing issues using keywords.
This PR is ready to merge and is not Work in Progress
- If the PR is work in progress, please add the prefix WIP: or [WIP] to the beginning of the
  title and remove the prefix when the PR is ready.

opbld33 · 2021-10-30T19:55:25Z

Docs Build status updates of commit b71e9b2:

✅ Validation status: passed

File	Status	Preview URL	Details
reference/7.1/Microsoft.PowerShell.Core/About/about_Operators.md	✅Succeeded	View (powershell-7.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching the docs.microsoft.com contributor guides
Post your question in the Docs support channel

sdwheeler

See my comments below and the comments in #8281

reference/7.1/Microsoft.PowerShell.Core/About/about_Operators.md

sdwheeler · 2021-11-11T22:39:19Z

reference/7.1/Microsoft.PowerShell.Core/About/about_Operators.md

+# Hexadecimal
+[Int] '0XF' -EQ 0XF -AND [Int] '#F' -EQ 0XF -AND [Int] '&HF' -EQ 0XF
+# Binary
+[Int] '0B1111' -EQ 0B1111


Hex and binary numbers are covered, in detail, in about_Numeric_Literals. And use lower case letters for the radix.

0xFF3C 0b1101011

Observe that #F is not a numeric literal but [INT] '#F' is valid.

Yes, but this documentation is not about all the different ways the type-casting can convert values. This is about the existence of the [type] cast operator. These more explicit examples belong elsewhere.

I gave these specific examples as a hint that conversions are weird (sometimes) and the coder should be prepared to handle unexpected results. I have removed the examples at your request.

sdwheeler · 2021-11-11T23:03:23Z

Thanks for the submission. Also, see my comments in #8282.

Also, when submitting changes to a file, the changes need to be made to all versions of the file. You have submitted two PRs for the same file (about_Operators). Please combine the changes in one PR.

If you want to wait for feedback before copying the changes to the other versions, mark the PR as a Work-in-Progress [WIP] as described in the PR template. After the feedback you can make the necessary changes to all version and update the PR.

Also, remove spurious conversion examples and improve style as requested.

opbld31 · 2021-11-12T12:07:14Z

Docs Build status updates of commit 62df05c:

✅ Validation status: passed

File	Status	Preview URL	Details
reference/7.1/Microsoft.PowerShell.Core/About/about_Operators.md	✅Succeeded	View (powershell-7.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching the docs.microsoft.com contributor guides
Post your question in the Docs support channel

opbld32 · 2021-11-12T17:22:04Z

Docs Build status updates of commit 2a142a6:

✅ Validation status: passed

File	Status	Preview URL	Details
reference/7.1/Microsoft.PowerShell.Core/About/about_Operators.md	✅Succeeded	View (powershell-7.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching the docs.microsoft.com contributor guides
Post your question in the Docs support channel

sdwheeler

This change looks good. Please copy the changes to the other versions.

opbld31 · 2021-11-15T22:13:24Z

Docs Build status updates of commit c811392:

✅ Validation status: passed

File	Status	Preview URL	Details
reference/7.1/Microsoft.PowerShell.Core/About/about_Operators.md	✅Succeeded	View (powershell-7.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching the docs.microsoft.com contributor guides
Post your question in the Docs support channel

Port from 7.1

opbld32 · 2021-11-15T22:15:37Z

Docs Build status updates of commit 7e1174e:

✅ Validation status: passed

File	Status	Preview URL	Details
reference/7.1/Microsoft.PowerShell.Core/About/about_Operators.md	✅Succeeded	View (powershell-7.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching the docs.microsoft.com contributor guides
Post your question in the Docs support channel

opbld31 · 2021-11-15T22:17:32Z

Docs Build status updates of commit 5ac9c20:

✅ Validation status: passed

File	Status	Preview URL	Details
reference/7.1/Microsoft.PowerShell.Core/About/about_Operators.md	✅Succeeded	View (powershell-7.1)
reference/7.2/Microsoft.PowerShell.Core/About/about_Operators.md	✅Succeeded	View (powershell-7.2)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching the docs.microsoft.com contributor guides
Post your question in the Docs support channel

Backport from 7.1

opbld31 · 2021-11-15T22:20:05Z

Docs Build status updates of commit 958a739:

✅ Validation status: passed

File	Status	Preview URL
reference/7.0/Microsoft.PowerShell.Core/About/about_Operators.md	✅Succeeded	View (powershell-7)
reference/7.1/Microsoft.PowerShell.Core/About/about_Operators.md	✅Succeeded	View (powershell-7.1)
reference/7.2/Microsoft.PowerShell.Core/About/about_Operators.md	✅Succeeded	View (powershell-7.2)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching the docs.microsoft.com contributor guides
Post your question in the Docs support channel

Backport from 7.1

opbld30 · 2021-11-15T22:22:44Z

Docs Build status updates of commit 11e857c:

✅ Validation status: passed

File	Status	Preview URL
reference/5.1/Microsoft.PowerShell.Core/About/about_Operators.md	✅Succeeded	View (powershell-5.1)
reference/7.0/Microsoft.PowerShell.Core/About/about_Operators.md	✅Succeeded	View (powershell-7)
reference/7.1/Microsoft.PowerShell.Core/About/about_Operators.md	✅Succeeded	View (powershell-7.1)
reference/7.2/Microsoft.PowerShell.Core/About/about_Operators.md	✅Succeeded	View (powershell-7.2)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching the docs.microsoft.com contributor guides
Post your question in the Docs support channel

More cast examples, add results

b71e9b2

sdwheeler mentioned this pull request Nov 11, 2021

op[]: mention lists of indices and non-collections #8282

Closed

24 tasks

sdwheeler requested changes Nov 11, 2021

View reviewed changes

sdwheeler changed the title ~~More cast examples, add results~~ [WIP] Add more examples to about_Operators Nov 11, 2021

About operator[]: non-arrays, lists of indices

62df05c

Also, remove spurious conversion examples and improve style as requested.

move hexadecimal string conversions to literals

2a142a6

sdwheeler requested changes Nov 15, 2021

View reviewed changes

yecril71pl added 2 commits November 15, 2021 23:11

-eq lc

c811392

fix $null.

7e1174e

Add more examples to about_Operators

5ac9c20

Port from 7.1

Add more examples to about_Operators

958a739

Backport from 7.1

Add more examples to about_Operators

11e857c

Backport from 7.1

yecril71pl changed the title ~~[WIP] Add more examples to about_Operators~~ Add more examples to about_Operators Nov 15, 2021

yecril71pl requested a review from sdwheeler November 16, 2021 10:14

sdwheeler merged commit f789b5a into MicrosoftDocs:staging Nov 16, 2021

yecril71pl deleted the patch-2 branch November 16, 2021 15:38

Conversation

yecril71pl commented Oct 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

opbld33 commented Oct 30, 2021

✅ Validation status: passed

Uh oh!

sdwheeler left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sdwheeler Nov 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yecril71pl Nov 12, 2021

Choose a reason for hiding this comment

Uh oh!

sdwheeler Nov 12, 2021

Choose a reason for hiding this comment

Uh oh!

yecril71pl Nov 12, 2021

Choose a reason for hiding this comment

Uh oh!

sdwheeler commented Nov 11, 2021

Uh oh!

opbld31 commented Nov 12, 2021

✅ Validation status: passed

Uh oh!

opbld32 commented Nov 12, 2021

✅ Validation status: passed

Uh oh!

sdwheeler left a comment

Choose a reason for hiding this comment

Uh oh!

opbld31 commented Nov 15, 2021

✅ Validation status: passed

Uh oh!

opbld32 commented Nov 15, 2021

✅ Validation status: passed

Uh oh!

opbld31 commented Nov 15, 2021

✅ Validation status: passed

Uh oh!

opbld31 commented Nov 15, 2021

✅ Validation status: passed

Uh oh!

opbld30 commented Nov 15, 2021

✅ Validation status: passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yecril71pl commented Oct 30, 2021 •

edited

Loading

sdwheeler Nov 11, 2021 •

edited

Loading