Skip to content

Fixes #4479 - Added the NoEmphasis parameter to PS7 document#5066

Merged
sdwheeler merged 2 commits intoMicrosoftDocs:stagingfrom
davidsmatlak:ds-issue4479
Nov 8, 2019
Merged

Fixes #4479 - Added the NoEmphasis parameter to PS7 document#5066
sdwheeler merged 2 commits intoMicrosoftDocs:stagingfrom
davidsmatlak:ds-issue4479

Conversation

@davidsmatlak
Copy link
Copy Markdown
Contributor

@davidsmatlak davidsmatlak commented Nov 7, 2019 •
edited by DCtheGeek
Loading

PR Summary

Acrolinx scores:
Original version: 95
Updated version: 96

PR Context

Select the type(s) of documents being changed.

Cmdlet reference & about_ topics

  • Version 7 content
  • Version 6 content
  • Version 5.1 content

Conceptual articles

  • Fundamental conceptual articles
  • Script sample articles
  • DSC articles
  • Gallery articles
  • JEA articles
  • WMF articles
  • SDK articles

PR Checklist

  • I have read the contributors guide and followed the style and process guidelines
  • PR has a meaningful title
  • PR is targeted at the staging branch
  • All relevant versions updated
  • Includes content related to issues and PRs - see Closing issues using keywords.
  • This PR is ready to merge and is not Work in Progress
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the
      title and remove the prefix when the PR is ready.

@opbld34
Copy link
Copy Markdown

opbld34 commented Nov 7, 2019

Docs Build status updates of commit 6d12304:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Utility/Select-String.md ✅Succeeded View (powershell-5.1)
reference/6/Microsoft.PowerShell.Utility/Select-String.md ✅Succeeded View (powershell-6)
reference/7/Microsoft.PowerShell.Utility/Select-String.md ✅Succeeded View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

sdwheeler
sdwheeler requested changes Nov 7, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description of NoEmphasis is backwards.

reference/7/Microsoft.PowerShell.Utility/Select-String.md Outdated

### -NoEmphasis

By default, the **NoEmphasis** parameter highlights the string found by `Select-String`. To disable
Copy link
Copy Markdown
Collaborator

@sdwheeler sdwheeler Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, Select-String highlights the string that matches the pattern you search for. The NoEmphasis disables this highlighting.

Copy link
Copy Markdown
Contributor Author

@davidsmatlak davidsmatlak Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! Fixed.

@opbld32
Copy link
Copy Markdown

opbld32 commented Nov 8, 2019

Docs Build status updates of commit 922eddb:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Utility/Select-String.md ✅Succeeded View (powershell-5.1)
reference/6/Microsoft.PowerShell.Utility/Select-String.md ✅Succeeded View (powershell-6)
reference/7/Microsoft.PowerShell.Utility/Select-String.md ✅Succeeded View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@sdwheeler sdwheeler merged commit 241379b into MicrosoftDocs:staging Nov 8, 2019
@davidsmatlak davidsmatlak deleted the ds-issue4479 branch November 22, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdwheeler sdwheeler sdwheeler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

document emphasis change for Select-string

4 participants

@davidsmatlak @opbld34 @opbld32 @sdwheeler