Merged
Conversation
Contributor
sdwheeler
requested changes
Jul 16, 2018
dsc/configurations.md
Outdated
| >You can make this happen either by "dot-sourcing" the script, | ||
| >or by running the configuration script by using F5 or clicking on the **Run Script** button in the ISE. | ||
| >To dot-source the script, run the command `. .\myConfig.ps1` where `myConfig.ps1` is the name of the script file that contains your configuration. | ||
| > **Note:** To call a configuration, the function must be in global scope (as with any other PowerShell function). |
Collaborator
There was a problem hiding this comment.
Make this into a NOTE block.
dsc/registryResource.md
Outdated
|
|
||
|
|
||
| <li>Expandable string (REG_EXPAND_SZ)</li></ul> | ||
| - String (REG_SZ) |
Collaborator
There was a problem hiding this comment.
This table is broken. You need to use the HTML markup for the list and close the table. Or turn the bullet list into a CSV list.
| a restricted runspace, on *srv2* for users in the *SMAdmins* group.\ | ||
| This example grants access to the session configuration _PSWAEndpoint_, | ||
| a restricted runspace, on _srv2_ for users in the _SMAdmins_ group.\ | ||
| **Note**: The computer name must be a fully qualified domain name |
Collaborator
There was a problem hiding this comment.
Turn this into a NOTE block
| |-|-| | ||
| |Key : Add-Computer|Value : http://go.microsoft.com/fwlink/p/?LinkID=135194| | ||
| |Key : Add-Content|Value : http://go.microsoft.com/fwlink/p/?LinkID=113278| | ||
| |Add-Computer|http://go.microsoft.com/fwlink/p/?LinkID=135194| |
Collaborator
There was a problem hiding this comment.
Change the URL to /powershell/module paths.
Contributor
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
sdwheeler
approved these changes
Jul 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to support markdig conversion.