Skip to content

update remote cmdlets for new hostname syntax#2298

Closed
SteveL-MSFT wants to merge 4 commits intoMicrosoftDocs:stagingfrom
SteveL-MSFT:ssh-hostname2
Closed

update remote cmdlets for new hostname syntax#2298
SteveL-MSFT wants to merge 4 commits intoMicrosoftDocs:stagingfrom
SteveL-MSFT:ssh-hostname2

Conversation

@SteveL-MSFT
Copy link
Copy Markdown
Contributor

@SteveL-MSFT SteveL-MSFT commented Apr 4, 2018

Update documentation to reflect changes in PR PowerShell/PowerShell#6558

Note that VSCode removed some trailing whitespace and not sure if critical to retain

Version(s) of document impacted

  • Impacts 6.1 document
  • Impacts 6.0 document
  • Impacts 5.1 document
  • Impacts 5.0 document
  • Impacts 4.0 document
  • Impacts 3.0 document

Reason(s) for not updating all version of documents

  • The documented feature was introduced in version (6.1) of PowerShell
  • This issue only shows up in version (list version(s) here) of the document
  • This PR partially fixes the issue, and issue # tracks the remaining work

@zjalexander
Copy link
Copy Markdown
Contributor

zjalexander commented Apr 4, 2018

❌ Validation status: errors

File Status Preview URL Details
❌Error Details

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@SteveL-MSFT SteveL-MSFT requested a review from PaulHigin April 4, 2018 12:36
@zjalexander
Copy link
Copy Markdown
Contributor

zjalexander commented Apr 4, 2018

✅ Validation status: passed

File Status Preview URL Details
reference/6/Microsoft.PowerShell.Core/Invoke-Command.md ✅Succeeded
reference/6/Microsoft.PowerShell.Core/New-PSSession.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

PaulHigin
PaulHigin suggested changes Apr 4, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update Enter-PSSession.md

@SteveL-MSFT SteveL-MSFT mentioned this pull request Apr 4, 2018
Merged
11 tasks
@zjalexander
Copy link
Copy Markdown
Contributor

zjalexander commented Apr 4, 2018

✅ Validation status: passed

File Status Preview URL Details
reference/6/Microsoft.PowerShell.Core/Enter-PSSession.md ✅Succeeded
reference/6/Microsoft.PowerShell.Core/Invoke-Command.md ✅Succeeded
reference/6/Microsoft.PowerShell.Core/New-PSSession.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

PaulHigin
PaulHigin approved these changes Apr 5, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT
Copy link
Copy Markdown
Contributor Author

SteveL-MSFT commented Apr 9, 2018

@sdwheeler the code PR was merged so we should merge this

@SteveL-MSFT SteveL-MSFT closed this Apr 9, 2018
@SteveL-MSFT SteveL-MSFT deleted the ssh-hostname2 branch April 9, 2018 11:30
@SteveL-MSFT SteveL-MSFT restored the ssh-hostname2 branch April 9, 2018 11:30
@sdwheeler
Copy link
Copy Markdown
Collaborator

sdwheeler commented Apr 9, 2018

@SteveL-MSFT merged for which version of PowerShell? If this is new for 6.1 then it should have been merged to the release branch, not staging.

@SteveL-MSFT
Copy link
Copy Markdown
Contributor Author

SteveL-MSFT commented Apr 10, 2018

@sdwheeler yeah, getting the hang of this. Will submit new PR for correct branch.

@sdwheeler sdwheeler mentioned this pull request Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sdwheeler sdwheeler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SteveL-MSFT @zjalexander @sdwheeler @PaulHigin