constraints.txt highlighting #1685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DonJayamanne
requested changes
May 14, 2018
news/2 Fixes/1053.md
Outdated
| @@ -0,0 +1 @@ | |||
| adds constraints syntax highlighting | |||
There was a problem hiding this comment.
Change to 'Add syntax highlighting to constraints.txt file to match that of piprequirements files'
There was a problem hiding this comment.
Move this file into 3 Code Health
WaleedSehgal
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1685 +/- ##
==========================================
+ Coverage 71.38% 71.53% +0.15%
==========================================
Files 277 277
Lines 13014 13014
Branches 2344 2344
==========================================
+ Hits 9290 9310 +20
+ Misses 3583 3569 -14
+ Partials 141 135 -6
Continue to review full report at Codecov.
|
brettcannon
suggested changes
May 14, 2018
package.json
Outdated
| "filenamePatterns": [ | ||
| "*-requirements.txt", | ||
| "requirements-*.txt", | ||
| "contraints-*.txt", |
Member
There was a problem hiding this comment.
You should also support files simply named constraints.txt (which requires simply adding that to "filenames" above.
DonJayamanne
approved these changes
May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1053
This pull request: