Skip to content

Conversation

@lingyv-li
Copy link

Fixes #1682

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@msftclas
Copy link

msftclas commented May 14, 2018

CLA assistant check
All CLA requirements met.

@codecov
Copy link

codecov bot commented May 14, 2018

Codecov Report

Merging #1684 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1684      +/-   ##
==========================================
+ Coverage   71.38%   71.52%   +0.13%     
==========================================
  Files         277      277              
  Lines       13014    13014              
  Branches     2344     2344              
==========================================
+ Hits         9290     9308      +18     
+ Misses       3583     3570      -13     
+ Partials      141      136       -5
Impacted Files Coverage Δ
...rc/client/debugger/PythonProcessCallbackHandler.ts 53.61% <0%> (-0.66%) ⬇️
src/client/debugger/mainV2.ts 77.82% <0%> (+2.82%) ⬆️
src/client/debugger/PythonProcess.ts 51.25% <0%> (+5.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe442f9...be721c8. Read the comment docs.

@@ -0,0 +1 @@
Fix setup script in contributing documentaion No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, it should be documentation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to 'Change yarn install script to include the keyword --lock-file'

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move 1682.md file into 3 Code Health directory

@DonJayamanne DonJayamanne merged commit 4f0af86 into microsoft:master May 14, 2018
@lingyv-li lingyv-li deleted the issue1682ContributingDoc branch May 14, 2018 18:48
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "--lockfile" tag to "yarn install" in contributing documentation

3 participants