Skip to content

Preserve files on exit (aka hot exit)#12400

Merged
Tyriar merged 58 commits intomasterfrom
tyriar/101_hot_exit
Oct 20, 2016
Merged

Preserve files on exit (aka hot exit)#12400
Tyriar merged 58 commits intomasterfrom
tyriar/101_hot_exit

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 21, 2016

Opening this now to more easily track changes during development.

Fixes #101

TODO

  • Backup files that are modified
  • Add a delay to file backup to reduce amount of disk access
  • Discard backups when files are no longer dirty
  • Ensure no collisions occur with backup files
    • Untitled files
    • Text files
  • Discard backups when a window is being closed and there is another window open
  • Retain backups when the last window is being exited
    • Ensure backups are up to date
  • Restore backups if available on first window launch
    • Restore text files
    • Restore untitled files
    • Launch a second window if the backup folder is different to that requested

Feedback Round 1

Clean up

  • Resolve remaining TODOs
  • Remove any console.log statements
  • Add some tests
  • Remove all empty lines at beginning of functions Preserve files on exit (aka hot exit) #12400 (review)
  • Have backup service tests use a temporary folder for backups (needed to have tests pass on Travis)

Known issues/follow ups

@Tyriar Tyriar added this to the September 2016 milestone Sep 21, 2016
@Tyriar Tyriar self-assigned this Sep 21, 2016
@Tyriar Tyriar modified the milestones: October 2016, September 2016 Sep 25, 2016
@Tyriar Tyriar force-pushed the tyriar/101_hot_exit branch from 79bfa37 to 3387b6c Compare October 14, 2016 08:28
@Tyriar
Copy link
Member Author

Tyriar commented Oct 20, 2016

Merging this now as everything's checked off or has follow up tasks and the push/branch CI jobs are passing 🎉 (failing on master due to 9e1b35b)

The main thing to call out here is that restoring is disabled on Mac until #13305 gets done.

@Tyriar Tyriar merged commit 112a795 into master Oct 20, 2016
@Tyriar Tyriar deleted the tyriar/101_hot_exit branch October 20, 2016 03:51
@Tyriar Tyriar mentioned this pull request Oct 21, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

workbench-hot-exit Preservation of unsaved changes across restarts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsaved files should be preserved on quit (hot exit)

3 participants