Fix | Fix SQL Exception Error State length to respect SQLSTATE Standards#977
Merged
cheenamalhotra merged 2 commits intomicrosoft:devfrom Mar 11, 2019
Merged
Fix | Fix SQL Exception Error State length to respect SQLSTATE Standards#977cheenamalhotra merged 2 commits intomicrosoft:devfrom
cheenamalhotra merged 2 commits intomicrosoft:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #977 +/- ##
============================================
- Coverage 50.58% 50.56% -0.02%
- Complexity 2915 2918 +3
============================================
Files 120 120
Lines 27987 27991 +4
Branches 4678 4679 +1
============================================
- Hits 14156 14155 -1
- Misses 11535 11540 +5
Partials 2296 2296
Continue to review full report at Codecov.
|
rene-ye
reviewed
Mar 8, 2019
ulvii
approved these changes
Mar 11, 2019
rene-ye
approved these changes
Mar 11, 2019
lilgreenbird
approved these changes
Mar 11, 2019
peterbae
approved these changes
Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #956
Calling
SQLException.getErrorState()would result in SQL State of length more than 5 characters allowed as per SQL State Specifications. This fix restricts length of SQLException Error State and appends zeroes (0) as needed to Error State received from SQL Server.As per SQL Server specifications, the values of ERROR_STATE ranges from 0 - 255 as one can raise an error with custom Error State using RAISEERROR as well. Accordingly, we must adjust trailing zeroes to the SQLException Error State.