Skip to content

Fix | Fixes regression caused in SQL Parser#950

Merged
cheenamalhotra merged 3 commits intomicrosoft:devfrom
cheenamalhotra:issue949
Feb 5, 2019
Merged

Fix | Fixes regression caused in SQL Parser#950
cheenamalhotra merged 3 commits intomicrosoft:devfrom
cheenamalhotra:issue949

Conversation

@cheenamalhotra
Copy link
Copy Markdown
Member

@cheenamalhotra cheenamalhotra commented Feb 1, 2019

Fixes #949

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 1, 2019

Codecov Report

Merging #950 into dev will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #950      +/-   ##
============================================
- Coverage     50.57%   50.53%   -0.04%     
+ Complexity     2919     2917       -2     
============================================
  Files           120      120              
  Lines         27987    27987              
  Branches       4678     4678              
============================================
- Hits          14154    14144      -10     
- Misses        11540    11547       +7     
- Partials       2293     2296       +3
Flag Coverage Δ Complexity Δ
#JDBC42 50.1% <100%> (ø) 2877 <0> (-3) ⬇️
#JDBC43 50.4% <100%> (-0.08%) 2909 <0> (-4)
Impacted Files Coverage Δ Complexity Δ
...a/com/microsoft/sqlserver/jdbc/ParameterUtils.java 64.44% <100%> (-8.89%) 20 <0> (-3)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.3% <0%> (-0.22%) 112% <0%> (+1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 43.48% <0%> (-0.2%) 315% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.48% <0%> (-0.1%) 0% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.53% <0%> (-0.06%) 0% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (+0.64%) 43% <0%> (+1%) ⬆️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 45.05% <0%> (+1.09%) 15% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5879de4...022d073. Read the comment docs.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 1, 2019 •
edited
Loading

Codecov Report

Merging #950 into dev will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #950      +/-   ##
============================================
- Coverage     50.57%   50.56%   -0.02%     
  Complexity     2919     2919              
============================================
  Files           120      120              
  Lines         27987    27987              
  Branches       4678     4678              
============================================
- Hits          14154    14151       -3     
- Misses        11540    11544       +4     
+ Partials       2293     2292       -1
Flag Coverage Δ Complexity Δ
#JDBC42 49.98% <100%> (-0.13%) 2871 <0> (-9)
#JDBC43 50.5% <100%> (+0.02%) 2915 <0> (+2) ⬆️
Impacted Files Coverage Δ Complexity Δ
...a/com/microsoft/sqlserver/jdbc/ParameterUtils.java 64.44% <100%> (-8.89%) 20 <0> (-3)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 62.06% <0%> (-0.44%) 90% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.3% <0%> (-0.22%) 111% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.41% <0%> (-0.18%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 43.86% <0%> (+0.19%) 319% <0%> (+3%) ⬆️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.79% <0%> (+0.43%) 43% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5879de4...5527f4a. Read the comment docs.

rene-ye
rene-ye previously approved these changes Feb 1, 2019
View reviewed changes
peterbae
peterbae previously approved these changes Feb 1, 2019
View reviewed changes
@cheenamalhotra cheenamalhotra mentioned this pull request Feb 1, 2019
Closed
lilgreenbird
lilgreenbird previously approved these changes Feb 4, 2019
View reviewed changes
@cheenamalhotra cheenamalhotra added this to the 7.2.1 milestone Feb 4, 2019
@cheenamalhotra cheenamalhotra merged commit d59dfec into microsoft:dev Feb 5, 2019
@rene-ye rene-ye mentioned this pull request Feb 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@peterbae peterbae peterbae approved these changes

@lilgreenbird lilgreenbird lilgreenbird left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.2.1

Development

Successfully merging this pull request may close these issues.

5 participants

@cheenamalhotra @codecov-io @rene-ye @lilgreenbird @peterbae