Skip to content

Fix random issue for SQLFloat random NaN value and improved TVPAllTypesTest for possible errors.#888

Merged
cheenamalhotra merged 5 commits intomicrosoft:devfrom
cheenamalhotra:randomfailures
Nov 26, 2018
Merged

Fix random issue for SQLFloat random NaN value and improved TVPAllTypesTest for possible errors.#888
cheenamalhotra merged 5 commits intomicrosoft:devfrom
cheenamalhotra:randomfailures

Conversation

@cheenamalhotra
Copy link
Copy Markdown
Member

@cheenamalhotra cheenamalhotra commented Nov 22, 2018

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 22, 2018 •
edited
Loading

Codecov Report

Merging #888 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #888      +/-   ##
============================================
- Coverage     48.72%   48.72%   -0.01%     
- Complexity     2799     2814      +15     
============================================
  Files           116      118       +2     
  Lines         27877    27863      -14     
  Branches       4650     4637      -13     
============================================
- Hits          13584    13575       -9     
- Misses        12088    12092       +4     
+ Partials       2205     2196       -9
Flag Coverage Δ Complexity Δ
#JDBC42 48.26% <ø> (+0.12%) 2775 <ø> (+25) ⬆️
#JDBC43 48.56% <ø> (-0.1%) 2801 <ø> (+6)
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.99% <0%> (-0.44%) 89% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.94% <0%> (-0.31%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.46% <0%> (-0.27%) 263% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 64.12% <0%> (-0.21%) 64% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 79.28% <0%> (-0.2%) 4% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.45% <0%> (-0.12%) 0% <0%> (ø)
...va/com/microsoft/sqlserver/jdbc/TimeoutPoller.java 83.78% <0%> (ø) 9% <0%> (?)
...a/com/microsoft/sqlserver/jdbc/TimeoutCommand.java 100% <0%> (ø) 5% <0%> (?)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.11% <0%> (+0.11%) 260% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 161b0bb...d4539c3. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.3 milestone Nov 22, 2018
lilgreenbird
lilgreenbird reviewed Nov 23, 2018
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/tvp/TVPAllTypesTest.java
lilgreenbird
lilgreenbird reviewed Nov 23, 2018
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/tvp/TVPAllTypesTest.java
lilgreenbird
lilgreenbird reviewed Nov 23, 2018
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/tvp/TVPAllTypesTest.java Outdated
lilgreenbird
lilgreenbird reviewed Nov 23, 2018
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/tvp/TVPAllTypesTest.java Outdated
peterbae
peterbae previously approved these changes Nov 23, 2018
View reviewed changes
peterbae
peterbae previously approved these changes Nov 23, 2018
View reviewed changes
lilgreenbird
lilgreenbird previously approved these changes Nov 23, 2018
View reviewed changes
@cheenamalhotra cheenamalhotra dismissed stale reviews from lilgreenbird and peterbae via d4539c3 November 26, 2018 20:55
@cheenamalhotra cheenamalhotra merged commit 218e736 into microsoft:dev Nov 26, 2018
ulvii pushed a commit that referenced this pull request Nov 30, 2018
@cheenamalhotra @ulvii
Fix | Fix random issues for SQLFloat type and improved TVPAllTypesTes…
7b1ca05 
…t for possible errors. (#888)
ulvii added a commit that referenced this pull request Nov 30, 2018
@ulvii
Revert "Fix | Fix random issues for SQLFloat type and improved TVPAll…
4a68057 
…TypesTest for possible errors. (#888)"

This reverts commit 7b1ca05.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@ulvii ulvii ulvii approved these changes

@peterbae peterbae peterbae approved these changes

@lilgreenbird lilgreenbird lilgreenbird left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.1.3

Development

Successfully merging this pull request may close these issues.

5 participants

@cheenamalhotra @codecov-io @lilgreenbird @ulvii @peterbae