Simplify boolean expressions by simon04 · Pull Request #857 · microsoft/mssql-jdbc

simon04 · 2018-10-26T21:53:43Z

No description provided.

codecov-io · 2018-10-26T22:15:08Z

Codecov Report

Merging #857 into dev will decrease coverage by 0.02%.
The diff coverage is 23.52%.

@@             Coverage Diff              @@
##                dev     #857      +/-   ##
============================================
- Coverage     48.69%   48.67%   -0.03%     
  Complexity     2797     2797              
============================================
  Files           116      116              
  Lines         27875    27875              
  Branches       4650     4650              
============================================
- Hits          13575    13567       -8     
- Misses        12095    12098       +3     
- Partials       2205     2210       +5

Flag	Coverage Δ	Complexity Δ
#JDBC42	`48.17% <23.52%> (-0.05%)`	`2753 <4> (-1)`
#JDBC43	`48.59% <23.52%> (+0.01%)`	`2792 <4> (+3)`	⬆️

Impacted Files	Coverage Δ	Complexity Δ
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java	`51.96% <0%> (ø)`	`212 <0> (ø)`	⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java	`56.16% <0%> (-0.14%)`	`0 <0> (ø)`
...main/java/com/microsoft/sqlserver/jdbc/Column.java	`34.73% <0%> (ø)`	`35 <0> (ø)`	⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java	`45.56% <0%> (ø)`	`66 <0> (ø)`	⬇️
...microsoft/sqlserver/jdbc/FailOverMapSingleton.java	`13.79% <0%> (ø)`	`0 <0> (ø)`	⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java	`64.12% <0%> (-0.21%)`	`64 <0> (ø)`
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java	`61.42% <16.66%> (+0.43%)`	`90 <0> (+1)`	⬆️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java	`48.09% <23.07%> (ø)`	`335 <4> (ø)`	⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java	`52.79% <66.66%> (+0.12%)`	`264 <0> (+1)`	⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java	`52.94% <0%> (-1.48%)`	`11% <0%> (-1%)`
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b331c3b...99c7f78. Read the comment docs.

simon04 · 2018-10-30T18:31:14Z

@rene-ye, thanks a lot for your detailed and applicable review. I addressed your suggestions and amended+rebased my commit.

This reverts commit c8fc626.