Skip to content

Fixed potential NullPointerException in logException()#844

Merged
ulvii merged 1 commit intomicrosoft:devfrom
ulvii:NullPointerFix
Oct 24, 2018
Merged

Fixed potential NullPointerException in logException()#844
ulvii merged 1 commit intomicrosoft:devfrom
ulvii:NullPointerFix

Conversation

@ulvii
Copy link
Copy Markdown
Contributor

@ulvii ulvii commented Oct 23, 2018

An Exception may have a null error message.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 23, 2018 •
edited
Loading

Codecov Report

Merging #844 into dev will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #844      +/-   ##
============================================
- Coverage     48.29%   48.27%   -0.02%     
+ Complexity     2781     2780       -1     
============================================
  Files           116      116              
  Lines         27877    27877              
  Branches       4651     4651              
============================================
- Hits          13462    13458       -4     
- Misses        12200    12203       +3     
- Partials       2215     2216       +1
Flag Coverage Δ Complexity Δ
#JDBC42 47.78% <100%> (-0.03%) 2736 <0> (-4)
#JDBC43 48.2% <100%> (-0.03%) 2776 <0> (-3)
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerException.java 77.44% <100%> (ø) 31 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 43.95% <0%> (-3.3%) 15% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.99% <0%> (-0.44%) 89% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.46% <0%> (-0.31%) 253% <0%> (-3%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.48% <0%> (-0.07%) 0% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.2% <0%> (ø) 107% <0%> (+1%) ⬆️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.46% <0%> (+0.12%) 262% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.28% <0%> (+0.29%) 0% <0%> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (+0.86%) 43% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5167636...bb1a159. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.2 milestone Oct 23, 2018
@ulvii ulvii merged commit ff6221d into microsoft:dev Oct 24, 2018
@ulvii ulvii deleted the NullPointerFix branch October 24, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

+2 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@lilgreenbird lilgreenbird lilgreenbird approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.1.2

Development

Successfully merging this pull request may close these issues.

5 participants

@ulvii @codecov-io @rene-ye @lilgreenbird @cheenamalhotra