Skip to content

Updating list of SQL keywords in DatabaseMetaData#829

Merged
cheenamalhotra merged 1 commit intomicrosoft:devfrom
pazkooda:feature/update-list-of-sql-keywords-in-metadata
Oct 24, 2018
Merged

Updating list of SQL keywords in DatabaseMetaData#829
cheenamalhotra merged 1 commit intomicrosoft:devfrom
pazkooda:feature/update-list-of-sql-keywords-in-metadata

Conversation

@pazkooda
Copy link
Copy Markdown
Contributor

@pazkooda pazkooda commented Oct 12, 2018

Source of keywords taken from TSQL documentation

@msftclas
Copy link
Copy Markdown

msftclas commented Oct 12, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@pazkooda pazkooda mentioned this pull request Oct 12, 2018
Merged
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 12, 2018 •
edited
Loading

Codecov Report

Merging #829 into dev will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #829      +/-   ##
============================================
- Coverage     48.38%   48.35%   -0.04%     
+ Complexity     2789     2786       -3     
============================================
  Files           116      116              
  Lines         27878    27880       +2     
  Branches       4651     4651              
============================================
- Hits          13489    13480       -9     
- Misses        12175    12186      +11     
  Partials       2214     2214
Flag Coverage Δ Complexity Δ
#JDBC42 47.89% <66.66%> (ø) 2744 <1> (+1) ⬆️
#JDBC43 48.2% <66.66%> (+0.05%) 2778 <1> (+2) ⬆️
Impacted Files Coverage Δ Complexity Δ
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 33.49% <66.66%> (+0.15%) 63 <1> (+1) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.94% <0%> (-1.48%) 11% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.69% <0%> (-0.35%) 255% <0%> (-4%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 63.52% <0%> (-0.21%) 64% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.46% <0%> (-0.13%) 263% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.58% <0%> (-0.1%) 0% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.4% <0%> (+0.05%) 0% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.73% <0%> (+0.43%) 108% <0%> (+1%) ⬆️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 45.05% <0%> (+1.09%) 15% <0%> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 59.52% <0%> (+1.19%) 34% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50d817...3821502. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.2 milestone Oct 18, 2018
@cheenamalhotra cheenamalhotra merged commit 895702a into microsoft:dev Oct 24, 2018
@pazkooda pazkooda deleted the feature/update-list-of-sql-keywords-in-metadata branch February 11, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.1.2

Development

Successfully merging this pull request may close these issues.

7 participants

@pazkooda @msftclas @codecov-io @rene-ye @lilgreenbird @peterbae @cheenamalhotra