Fix issues with apostrophe being passed in table name + Improvements in SQLServerParameterMetadata#780
Merged
cheenamalhotra merged 21 commits intomicrosoft:devfrom Sep 25, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #780 +/- ##
=========================================
Coverage 48.53% 48.53%
- Complexity 2806 2810 +4
=========================================
Files 116 116
Lines 27862 27862
Branches 4641 4647 +6
=========================================
Hits 13523 13523
- Misses 12197 12206 +9
+ Partials 2142 2133 -9
Continue to review full report at Codecov.
|
cheenamalhotra
changed the title
lilgreenbird
reviewed
Sep 5, 2018
lilgreenbird
previously approved these changes
Sep 18, 2018
ulvii
reviewed
Sep 18, 2018
| * Object name to be passed as String | ||
| * @return Converted object name | ||
| */ | ||
| static String escapeQuotes(String name) { |
Contributor
There was a problem hiding this comment.
Can we rename this method to escapeSingleQuotes?
| static String unsupportedTableName = "[BulkCopyUnsupportedTable'" + UUID + "]"; | ||
| static String squareBracketTableName = "[peter]]]]test'" + UUID + "]"; | ||
| static String doubleQuoteTableName = "\"peter\"\"\"\"test'" + UUID + "\""; | ||
|
|
ulvii
reviewed
Sep 19, 2018
ulvii
reviewed
Sep 19, 2018
| rsProcedureMeta.getColumn(8).setFilter(new ZeroFixupFilter()); | ||
| rsProcedureMeta.getColumn(9).setFilter(new ZeroFixupFilter()); | ||
| rsProcedureMeta.getColumn(17).setFilter(new ZeroFixupFilter()); | ||
| // DO NOT close the Statement as resultSet 'rsProcedureMeta' is required by other APIs |
Contributor
There was a problem hiding this comment.
Try-with-resources will close the statement though. Is this comment still accurate?
ulvii
reviewed
Sep 19, 2018
| bFound = rsProcedureMeta.absolute(param); | ||
| } else { | ||
| bFound = rsProcedureMeta.absolute(param + 1); // Note row 1 is the 'return value' meta data | ||
| if ((stmtParent).bReturnValueSyntax && isTVP) { |
Contributor
There was a problem hiding this comment.
I can't figure out why the variable would be named bFound. Please rename it to a descriptive one.
ulvii
reviewed
Sep 20, 2018
ulvii
reviewed
Sep 20, 2018
| return queryMetaMap.size(); | ||
| } else { | ||
| // Row 1 is Return Type metadata | ||
| return procMetadata.size() - 1; |
lilgreenbird
previously approved these changes
Sep 22, 2018
lilgreenbird
approved these changes
Sep 24, 2018
rene-ye
approved these changes
Sep 24, 2018
ulvii
approved these changes
Sep 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.