Skip to content

Apply the collation name change to UTF8SupportTest#741

Merged
ulvii merged 1 commit intomicrosoft:devfrom
ulvii:utf8Collation
Jul 9, 2018
Merged

Apply the collation name change to UTF8SupportTest#741
ulvii merged 1 commit intomicrosoft:devfrom
ulvii:utf8Collation

Conversation

@ulvii
Copy link
Copy Markdown
Contributor

@ulvii ulvii commented Jul 9, 2018

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 9, 2018 •
edited
Loading

Codecov Report

Merging #741 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #741      +/-   ##
============================================
- Coverage     48.52%   48.51%   -0.02%     
+ Complexity     2773     2767       -6     
============================================
  Files           116      116              
  Lines         27342    27342              
  Branches       4562     4562              
============================================
- Hits          13268    13264       -4     
+ Misses        11909    11906       -3     
- Partials       2165     2172       +7
Flag Coverage Δ Complexity Δ
#JDBC42 48.01% <ø> (-0.02%) 2725 <ø> (-1)
#JDBC43 48.41% <ø> (+0.02%) 2762 <ø> (-4) ⬇️
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 43.4% <0%> (-2.02%) 106% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 42.69% <0%> (-1.13%) 14% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.36% <0%> (-0.65%) 42% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.46% <0%> (-0.36%) 244% <0%> (-3%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.12% <0%> (-0.06%) 0% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 62.76% <0%> (+0.2%) 64% <0%> (ø) ⬇️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.33% <0%> (+0.44%) 88% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.63% <0%> (+0.53%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2cf217...612f49c. Read the comment docs.

@ulvii ulvii merged commit c4b6e64 into microsoft:dev Jul 9, 2018
@ulvii ulvii deleted the utf8Collation branch July 9, 2018 23:45
@cheenamalhotra cheenamalhotra added this to the 7.0.0 milestone Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

+2 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ulvii @codecov-io @rene-ye @cheenamalhotra @peterbae @lilgreenbird