Skip to content

HostNameInCertificate Fix#644

Merged
peterbae merged 7 commits intomicrosoft:devfrom
peterbae:github-623
May 29, 2018
Merged

HostNameInCertificate Fix#644
peterbae merged 7 commits intomicrosoft:devfrom
peterbae:github-623

Conversation

@peterbae
Copy link
Copy Markdown
Contributor

@peterbae peterbae commented Mar 5, 2018

Fixes issue #623

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 5, 2018 •
edited
Loading

Codecov Report

Merging #644 into dev will decrease coverage by 0.04%.
The diff coverage is 37.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #644      +/-   ##
============================================
- Coverage     48.17%   48.13%   -0.05%     
+ Complexity     2585     2584       -1     
============================================
  Files           114      114              
  Lines         26578    26586       +8     
  Branches       4453     4455       +2     
============================================
- Hits          12805    12796       -9     
- Misses        11634    11647      +13     
- Partials       2139     2143       +4
Flag Coverage Δ Complexity Δ
#JDBC42 48.01% <37.5%> (+0.03%) 2576 <0> (+1) ⬆️
#JDBC43 48.02% <37.5%> (-0.02%) 2580 <0> (+1)
Impacted Files Coverage Δ Complexity Δ
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.67% <37.5%> (-0.03%) 288 <0> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.11% <0%> (-0.3%) 0% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39.18% <0%> (-0.22%) 43% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.21% <0%> (-0.2%) 245% <0%> (-2%)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 77.85% <0%> (-0.17%) 4% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.26% <0%> (-0.07%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.67% <0%> (ø) 241% <0%> (+2%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.41% <0%> (+0.44%) 107% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58f4f1d...4b128db. Read the comment docs.

@rene-ye rene-ye self-requested a review March 6, 2018 18:24
rene-ye
rene-ye previously approved these changes Mar 6, 2018
View reviewed changes
@cheenamalhotra cheenamalhotra modified the milestone: 6.5.0 Mar 6, 2018
@peterbae peterbae mentioned this pull request Mar 9, 2018
Closed
@cheenamalhotra cheenamalhotra requested a review from ulvii March 12, 2018 21:41
@cheenamalhotra cheenamalhotra added this to the 6.5.1 milestone Mar 12, 2018
@ulvii ulvii removed this from the 6.5.1 milestone Mar 30, 2018
@peterbae
Copy link
Copy Markdown
Contributor Author

peterbae commented Apr 4, 2018

Closing this as this fix was unnecessary, the issue was apparently coming from Azure's end.

@peterbae peterbae closed this Apr 4, 2018
@peterbae peterbae reopened this May 14, 2018
@rene-ye rene-ye added this to the 6.5.3 milestone May 29, 2018
@peterbae peterbae merged commit eb312a0 into microsoft:dev May 29, 2018
@peterbae peterbae deleted the github-623 branch May 29, 2018 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@ulvii ulvii Awaiting requested review from ulvii

+2 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@lilgreenbird lilgreenbird lilgreenbird approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.5.3

Development

Successfully merging this pull request may close these issues.

6 participants

@peterbae @codecov-io @rene-ye @lilgreenbird @cheenamalhotra @ulvii