Tvp schema error fix.#38
Conversation
|
@gstojsic thank you very much for your contribution. As a design decision, we decided to support TVP with The fix that you provided is a real fix for the case with stored procedure. We can get the TVP schema from stored procedure. However, TVP should work with Prepared Statement (without stored procedure) as well. With Prepared Statement, |
|
I did not really understand the point of your comment. The fix is really for the case with the stored procedure which now does not work properly because it takes only the type name into account without the schema. The fix does not affect the Prepared statement case. Did you want me to provide the fix for the Prepared statement also? Also I did not understand the first part. TVP's are handled in setObject methods as I can see from the source code. For example: |
|
@gstojsic I have talked with our team here, we all think the fix that you provided is great and we really appreciate it. After testing is done on our side, we will accept your PR and make TVP support |
|
hello @gstojsic we very appreciate your idea on how to fix this issue, it is awesome. however, the fix is causing regression failures on our test lab. We will look into those regression failures and provide another fix based on your idea. For now, we are going to close this PR. Thank you again. |
This is in reference to issue (#37). Essentially the
getParameterTypeName(int param)method returns only the type name. This causes the error when the TVP is in a schema different than dbo. I have taken theSS_TYPE_SCHEMA_NAMEparameter returned by thesp_sproc_columns_100stored procedure for the schema name and built the tvp name from that.