SonarQube fixes#301
Merged
AfsanehR-zz merged 15 commits intomicrosoft:RTW_6.2.0from May 25, 2017
Merged
Conversation
…e such as "StringBuilder". Remove uselsess assignment to local variable.
…left side of comparison
Codecov Report
@@ Coverage Diff @@
## RTW_6.2.0 #301 +/- ##
===============================================
+ Coverage 37.2% 37.37% +0.17%
- Complexity 1664 1676 +12
===============================================
Files 103 103
Lines 23674 23684 +10
Branches 3882 3880 -2
===============================================
+ Hits 8808 8853 +45
+ Misses 13275 13245 -30
+ Partials 1591 1586 -5
Continue to review full report at Codecov.
|
ahmad-ibra
suggested changes
May 24, 2017
ahmad-ibra
left a comment
ahmad-ibra
left a comment
There was a problem hiding this comment.
Other than that 1 change, everything else looks good
| XAReturnValue r = DTC_XA_Interface(XA_RECOVER, null, flags | tightlyCoupled); | ||
| int offset = 0; | ||
| Vector<XidImpl> v = new Vector<XidImpl>(); | ||
| ArrayList<XidImpl> v = new ArrayList<XidImpl>(); |
There was a problem hiding this comment.
the variable name doesnt mean anything anymore now that its an array list instead of a vector. It might be better to rename it to something like al
ahmad-ibra
approved these changes
May 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.