Skip to content

Fix password logging#298

Merged
ahmad-ibra merged 3 commits intomicrosoft:RTW_6.2.0from
ahmad-ibra:fixPasswordLogging
May 23, 2017
Merged

Fix password logging#298
ahmad-ibra merged 3 commits intomicrosoft:RTW_6.2.0from
ahmad-ibra:fixPasswordLogging

Conversation

@ahmad-ibra
Copy link
Copy Markdown

@ahmad-ibra ahmad-ibra commented May 18, 2017

FIPS property trustStorePassword was being logged

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 18, 2017 •
edited
Loading

Codecov Report

Merging #298 into RTW_6.2.0 will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##             RTW_6.2.0     #298      +/-   ##
===============================================
- Coverage         37.2%   37.12%   -0.08%     
+ Complexity        1664     1658       -6     
===============================================
  Files              103      103              
  Lines            23674    23675       +1     
  Branches          3882     3882              
===============================================
- Hits              8808     8790      -18     
- Misses           13275    13293      +18     
- Partials          1591     1592       +1
Flag Coverage Δ Complexity Δ
#JDBC41 37.01% <100%> (-0.11%) 1651 <0> (-9)
#JDBC42 37.09% <100%> (-0.04%) 1658 <0> (-2)
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 45.28% <100%> (+0.12%) 60 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 41.57% <0%> (-3.38%) 14% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 47.79% <0%> (-1.48%) 9% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 26.44% <0%> (-0.5%) 181% <0%> (-4%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 48.87% <0%> (-0.22%) 211% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 46.04% <0%> (-0.07%) 0% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 29.68% <0%> (ø) 56% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 36.96% <0%> (+0.13%) 0% <0%> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 70.03% <0%> (+0.16%) 5% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c85245a...91c8c6e. Read the comment docs.

@ahmad-ibra ahmad-ibra merged commit 368b662 into microsoft:RTW_6.2.0 May 23, 2017
@ahmad-ibra ahmad-ibra deleted the fixPasswordLogging branch May 23, 2017 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ahmad-ibra @codecov-io @lilgreenbird @msftclas @ajlam