Skip to content

Throw SQLServer exception in case of invalid value for TVP#285

Merged
AfsanehR-zz merged 1 commit intomicrosoft:devfrom
AfsanehR-zz:TVPExceptions
May 10, 2017
Merged

Throw SQLServer exception in case of invalid value for TVP#285
AfsanehR-zz merged 1 commit intomicrosoft:devfrom
AfsanehR-zz:TVPExceptions

Conversation

@AfsanehR-zz
Copy link
Copy Markdown
Contributor

@AfsanehR-zz AfsanehR-zz commented May 10, 2017

instead of illegal argument exception.
IOBuffer changes only has a try-catch added that shows big diff.
Also, changed the error message id of R_BulkCSVDataSchemaMismatch ro R_CSVDataSchemaMismatch so it could be used both for Bulkcopy and TVP.

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 10, 2017 •
edited
Loading

Codecov Report

Merging #285 into dev will increase coverage by <.01%.
The diff coverage is 22.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #285      +/-   ##
============================================
+ Coverage     37.21%   37.22%   +<.01%     
+ Complexity     1666     1663       -3     
============================================
  Files           103      103              
  Lines         23664    23667       +3     
  Branches       3880     3880              
============================================
+ Hits           8806     8809       +3     
+ Misses        13267    13263       -4     
- Partials       1591     1595       +4
Flag Coverage Δ Complexity Δ
#JDBC41 37.1% <22.36%> (-0.01%) 1655 <0> (-4)
#JDBC42 37.07% <22.36%> (-0.08%) 1654 <0> (-10)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerBulkCSVFileRecord.java 40.56% <0%> (ø) 26 <0> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 46.04% <22.97%> (-0.05%) 0 <0> (ø)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 47.79% <0%> (-1.48%) 9% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-1.13%) 16% <0%> (-1%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 45.15% <0%> (-0.48%) 60% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 69.86% <0%> (-0.17%) 4% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 47.91% <0%> (-0.08%) 204% <0%> (+1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 27.78% <0%> (+0.12%) 191% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b96ae...891a84a. Read the comment docs.

@AfsanehR-zz AfsanehR-zz requested a review from ahmad-ibra May 10, 2017 22:13
@AfsanehR-zz AfsanehR-zz merged commit c706d55 into microsoft:dev May 10, 2017
@AfsanehR-zz AfsanehR-zz deleted the TVPExceptions branch May 26, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ahmad-ibra ahmad-ibra ahmad-ibra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AfsanehR-zz @codecov-io @ahmad-ibra @lilgreenbird @ajlam