Skip to content

Handle ClassCastException #260

Merged
Suraiya-Hameed merged 2 commits intomicrosoft:devfrom
Suraiya-Hameed:CatchCastException
Apr 24, 2017
Merged

Handle ClassCastException #260
Suraiya-Hameed merged 2 commits intomicrosoft:devfrom
Suraiya-Hameed:CatchCastException

Conversation

@Suraiya-Hameed
Copy link
Copy Markdown
Contributor

@Suraiya-Hameed Suraiya-Hameed commented Apr 21, 2017

No description provided.

@Suraiya-Hameed
Copy link
Copy Markdown
Contributor Author

Suraiya-Hameed commented Apr 21, 2017 •
edited
Loading

It is the same source code as before, just an extra try/catch, that resulted in formatting a huge chunk of code.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 21, 2017 •
edited
Loading

Codecov Report

Merging #260 into dev will increase coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #260      +/-   ##
============================================
+ Coverage     33.78%   33.86%   +0.07%     
  Complexity     1530     1530              
============================================
  Files           101      101              
  Lines         23584    23590       +6     
  Branches       3867     3867              
============================================
+ Hits           7969     7988      +19     
+ Misses        14045    14030      -15     
- Partials       1570     1572       +2
Flag Coverage Δ Complexity Δ
#JDBC41 33.77% <48.94%> (+0.09%) 1526 <0> (+2) ⬆️
#JDBC42 33.66% <46.84%> (+0.01%) 1523 <0> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 46.1% <50%> (-0.13%) 192 <0> (-2)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 69.69% <0%> (-0.17%) 4% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 34.71% <0%> (-0.07%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 25.17% <0%> (+0.08%) 179% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 27.45% <0%> (+0.44%) 49% <0%> (+1%) ⬆️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 38.03% <0%> (+0.48%) 0% <0%> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 39.05% <0%> (+1.18%) 27% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7228f12...279d051. Read the comment docs.

Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into Ca…
279d051 
…tchCastException

# Conflicts:
#	src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
@Suraiya-Hameed Suraiya-Hameed merged commit a73ed0a into microsoft:dev Apr 24, 2017
@Suraiya-Hameed Suraiya-Hameed deleted the CatchCastException branch April 24, 2017 22:43
@v-nisidh v-nisidh added this to the 6.1.7 milestone Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ahmad-ibra ahmad-ibra ahmad-ibra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.1.7

Development

Successfully merging this pull request may close these issues.

6 participants

@Suraiya-Hameed @codecov-io @ahmad-ibra @lilgreenbird @ajlam @v-nisidh