have cause of SQLServerException exception at any place where it possible#202
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #202 +/- ##
============================================
+ Coverage 33.45% 33.53% +0.08%
- Complexity 1488 1489 +1
============================================
Files 97 97
Lines 23390 23390
Branches 3840 3840
============================================
+ Hits 7824 7845 +21
+ Misses 14002 13980 -22
- Partials 1564 1565 +1
Continue to review full report at Codecov.
|
v-nisidh
left a comment
v-nisidh
left a comment
There was a problem hiding this comment.
Please create some tests which expects exceptions and test if exceptions having appropriate cause.
v-nisidh
left a comment
v-nisidh
left a comment
There was a problem hiding this comment.
Approved. Please fix 2 Review Comments before merge.
| } | ||
|
|
||
| private void dropWaitForDelayProcedure(SQLServerConnection conn) throws SQLException { | ||
| String sql = " IF EXISTS (select * from sysobjects where id = object_id(N'" + waitForDelaySPName |
There was a problem hiding this comment.
Use new Utility for delete object. Utils.dropObjectIfExists(...)
There was a problem hiding this comment.
This PR is pretty old, before we have this Utils.dropObjectIfExists(...) method.
There was a problem hiding this comment.
changed to Utils.dropProcedureIfExists after merging/updating with Dev branch
| * | ||
| * @return location of resource file | ||
| */ | ||
| static String getCurrentClassPath() { |
There was a problem hiding this comment.
Can you move this to Util class as it is very much common to whole framework.
@v-suhame : Possibly we already might be having this functionality of getCurrentClassPath somewhere.
There was a problem hiding this comment.
we have getCurrentClassPath() in BulkCopyCSVTest as well. I moved them into Utils class.
4 participants
for issue #139