Fix random failure in BulkCopyColumnMapping test#165
Merged
v-nisidh merged 2 commits intomicrosoft:devfrom Mar 7, 2017
ahmad-ibra:dev
Merged
Fix random failure in BulkCopyColumnMapping test#165v-nisidh merged 2 commits intomicrosoft:devfrom ahmad-ibra:dev
v-nisidh merged 2 commits intomicrosoft:devfrom
ahmad-ibra:dev
Conversation
Before, when two random tables are created, there was a small chance that they would have identical schemas. This caused the ImplicitMismatchCM test case to pass when it was expected to fail. Modified creation of destination table to always have a different schema from the source table.
Codecov Report
@@ Coverage Diff @@
## dev #165 +/- ##
===========================================
- Coverage 29.7% 29.56% -0.15%
+ Complexity 1248 1246 -2
===========================================
Files 97 97
Lines 23305 23305
Branches 3871 3871
===========================================
- Hits 6923 6889 -34
- Misses 15028 15064 +36
+ Partials 1354 1352 -2
Continue to review full report at Codecov.
|
v-nisidh
reviewed
Mar 2, 2017
| * @param autoGenerateSchema | ||
| * @param alternateSchema | ||
| */ | ||
| DBSchema(boolean autoGenerateSchema, boolean alternateSchema) { |
Contributor
There was a problem hiding this comment.
Instead of copy paste you can use shuffle / reverse.
if(alternateSchema) {
Collections.shuffle(sqlTypes);
or
Collections.reverse(sqlTypes);
}
DBSchema(boolean autoGenerateSchema, boolean alternateSchema) {
this(autoGenerateSchema);
if(alternateSchema) {
Collections.shuffle(this.sqlTypes);
}
v-nisidh
suggested changes
Mar 3, 2017
Contributor
v-nisidh
left a comment
v-nisidh
left a comment
There was a problem hiding this comment.
Think of rewriting DBSchema(...) by calling other constructor and on top of that shuffling instead of copy paste.
| * @param alternateShcema | ||
| * <code>true</code>: creates table with alternate schema | ||
| */ | ||
| public DBTable(boolean autoGenerateSchema, boolean unicode, boolean alternateSchema) { |
Contributor
There was a problem hiding this comment.
We can reduced copy paste by changing public DBTable(boolean autoGenerateSchema) and public DBTable(boolean autoGenerateSchema, boolean unicode)
Example:
public DBTable(boolean autoGenerateSchema) {
this(autoGenerateSchema, false,false);
}
v-nisidh
approved these changes
Mar 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, when two random tables are created, there was a small chance that they would have identical schemas. This caused the ImplicitMismatchCM test case to pass when it was expected to fail. Modified creation of destination table to always have a different schema from the source table.