Skip to content

Performance | Code cleanup to improve performance #1075

Merged
ulvii merged 7 commits intomicrosoft:devfrom
ulvii:perfImprovements
Jun 25, 2019
Merged

Performance | Code cleanup to improve performance #1075
ulvii merged 7 commits intomicrosoft:devfrom
ulvii:perfImprovements

Conversation

@ulvii
Copy link
Copy Markdown
Contributor

@ulvii ulvii commented Jun 4, 2019

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 4, 2019 •
edited
Loading

Codecov Report

Merging #1075 into dev will decrease coverage by 1.6%.
The diff coverage is 37.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1075      +/-   ##
============================================
- Coverage     54.62%   53.01%   -1.61%     
+ Complexity     3375     3162     -213     
============================================
  Files           124      119       -5     
  Lines         28755    28053     -702     
  Branches       4769     4678      -91     
============================================
- Hits          15706    14871     -835     
- Misses        10785    10953     +168     
+ Partials       2264     2229      -35
Impacted Files Coverage Δ Complexity Δ
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 60.97% <ø> (-0.53%) 0 <0> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.12% <ø> (ø) 91 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 46.39% <ø> (-2.2%) 71 <0> (-9)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 80.3% <ø> (ø) 6 <0> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerBulkCSVFileRecord.java 47.39% <0%> (-0.46%) 28 <0> (ø)
...m/microsoft/sqlserver/jdbc/KerbAuthentication.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...crosoft/sqlserver/jdbc/dns/DNSKerberosLocator.java 0% <0%> (-37.5%) 0 <0> (-1)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.64% <100%> (-0.14%) 0 <0> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/TVP.java 43.72% <100%> (ø) 26 <0> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerCallableStatement.java 29.51% <100%> (-0.09%) 100 <0> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5333f10...b97465a. Read the comment docs.

@ulvii ulvii added this to the 7.4.0 milestone Jun 20, 2019
@ulvii ulvii requested review from lilgreenbird and rene-ye June 22, 2019 01:10
rene-ye
rene-ye reviewed Jun 24, 2019
View reviewed changes
Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
@ulvii ulvii merged commit d076781 into microsoft:dev Jun 25, 2019
@ulvii ulvii deleted the perfImprovements branch June 25, 2019 22:35
@dmitri-blinov
Copy link
Copy Markdown

dmitri-blinov commented Jul 29, 2019

Replacing String.startsWith(x) with String.charAt(0) == x may lead to an exception being thrown for the empty string "".

@ulvii ulvii mentioned this pull request Jul 29, 2019
Merged
@ulvii
Copy link
Copy Markdown
Contributor Author

ulvii commented Jul 29, 2019

Hi @dmitri-blinov ,
Thank you for bringing this to our attention. I reverted the changes to not introduce a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@lilgreenbird lilgreenbird lilgreenbird approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ulvii @codecov-io @dmitri-blinov @rene-ye @lilgreenbird