Skip to content

Fix | Misleading error message in CallableStatement#1064

Merged
rene-ye merged 19 commits intomicrosoft:devfrom
rene-ye:issue1059
Jun 10, 2019
Merged

Fix | Misleading error message in CallableStatement#1064
rene-ye merged 19 commits intomicrosoft:devfrom
rene-ye:issue1059

Conversation

@rene-ye
Copy link
Copy Markdown
Member

@rene-ye rene-ye commented May 22, 2019 •
edited
Loading

Fixed an issue where CallableStatement was not setting parameter indexes properly when columns aren't found via column name lookup. This results in the driver returning a misleading error message early instead of executing the statement and receiving the proper message from server. Addresses issue #1059.

@cheenamalhotra cheenamalhotra added this to the 7.3.1 milestone May 22, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 23, 2019 •
edited
Loading

Codecov Report

Merging #1064 into dev will increase coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1064      +/-   ##
============================================
+ Coverage     53.08%   53.12%   +0.04%     
- Complexity     3159     3172      +13     
============================================
  Files           119      119              
  Lines         28022    28121      +99     
  Branches       4688     4694       +6     
============================================
+ Hits          14875    14940      +65     
- Misses        10912    10949      +37     
+ Partials       2235     2232       -3
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerCallableStatement.java 29.6% <33.33%> (+0.08%) 100 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 45.05% <0%> (-2.2%) 15% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.51% <0%> (-0.87%) 112% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 60.83% <0%> (-0.67%) 0% <0%> (ø)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 49.55% <0%> (-0.07%) 393% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 51.56% <0%> (-0.07%) 255% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39.22% <0%> (+0.21%) 44% <0%> (+1%) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 80.3% <0%> (+0.22%) 6% <0%> (ø) ⬇️
...rosoft/sqlserver/jdbc/InternalSpatialDatatype.java 91.66% <0%> (+0.36%) 6% <0%> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 60.94% <0%> (+1.18%) 35% <0%> (+1%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91c7ea...1e57d55. Read the comment docs.

peterbae
peterbae reviewed May 23, 2019
View reviewed changes
Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCallableStatement.java Outdated
cheenamalhotra
cheenamalhotra reviewed May 30, 2019
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java
rene-ye and others added 10 commits May 30, 2019 13:13
@rene-ye @cheenamalhotra
Update src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/C…
e192ad7 
…allableMixedTest.java

Co-Authored-By: Cheena Malhotra <[email protected]>
@rene-ye @cheenamalhotra
Update src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/C…
63e990e 
…allableMixedTest.java

Co-Authored-By: Cheena Malhotra <[email protected]>
@rene-ye @cheenamalhotra
Update src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/C…
d231177 
…allableMixedTest.java

Co-Authored-By: Cheena Malhotra <[email protected]>
@rene-ye @cheenamalhotra
Update src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/C…
0028981 
…allableMixedTest.java

Co-Authored-By: Cheena Malhotra <[email protected]>
@rene-ye @cheenamalhotra
Update src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/C…
292f928 
…allableMixedTest.java

Co-Authored-By: Cheena Malhotra <[email protected]>
@rene-ye @cheenamalhotra
Update src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/C…
eb12123 
…allableMixedTest.java

Co-Authored-By: Cheena Malhotra <[email protected]>
@rene-ye
Fix | Drop resources in finally block
8dad43a
@rene-ye
Merge branch 'issue1059' of https://github.com/rene-ye/mssql-jdbc int…
e27e995 
…o issue1059
@rene-ye
Fix | Compilation Error
880235e
@rene-ye
Fix | Tests
c01c725
cheenamalhotra
cheenamalhotra reviewed May 30, 2019
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java Outdated
@rene-ye rene-ye requested a review from lilgreenbird June 3, 2019 16:45
cheenamalhotra
cheenamalhotra previously approved these changes Jun 5, 2019
View reviewed changes
lilgreenbird
lilgreenbird reviewed Jun 5, 2019
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/TestResource.java
ulvii
ulvii reviewed Jun 9, 2019
View reviewed changes
Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCallableStatement.java
@rene-ye rene-ye merged commit 9ff36a5 into microsoft:dev Jun 10, 2019
@ulvii ulvii mentioned this pull request Jun 25, 2019
Closed
@rene-ye rene-ye deleted the issue1059 branch October 10, 2019 23:05
@mprins mprins mentioned this pull request May 25, 2020
Closed
@jocstar jocstar mentioned this pull request Feb 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

+3 more reviewers

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@ulvii ulvii ulvii approved these changes

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.3.1

Development

Successfully merging this pull request may close these issues.

6 participants

@rene-ye @codecov-io @lilgreenbird @cheenamalhotra @ulvii @peterbae