Skip to content

Fix | Fix issues with Login Timeout not getting applied appropriately.#1049

Merged
cheenamalhotra merged 5 commits intomicrosoft:devfrom
cheenamalhotra:fix1048
May 15, 2019
Merged

Fix | Fix issues with Login Timeout not getting applied appropriately.#1049
cheenamalhotra merged 5 commits intomicrosoft:devfrom
cheenamalhotra:fix1048

Conversation

@cheenamalhotra
Copy link
Copy Markdown
Member

@cheenamalhotra cheenamalhotra commented Apr 25, 2019

Fixes #1048

@cheenamalhotra cheenamalhotra mentioned this pull request Apr 25, 2019
Closed
peterbae
peterbae previously approved these changes Apr 25, 2019
View reviewed changes
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 26, 2019 •
edited
Loading

Codecov Report

Merging #1049 into dev will increase coverage by 2.24%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1049      +/-   ##
============================================
+ Coverage     50.68%   52.92%   +2.24%     
- Complexity     3057     3138      +81     
============================================
  Files           119      119              
  Lines         27941    27944       +3     
  Branches       4668     4668              
============================================
+ Hits          14162    14790     +628     
+ Misses        11461    10927     -534     
+ Partials       2318     2227      -91
Impacted Files Coverage Δ Complexity Δ
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 83.18% <83.33%> (+0.03%) 37 <0> (+1) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.51% <0%> (-0.44%) 111% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.79% <0%> (-0.22%) 43% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 67.41% <0%> (-0.21%) 64% <0%> (ø)
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 73.86% <0%> (+0.22%) 103% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.59% <0%> (+0.23%) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 51.56% <0%> (+0.3%) 255% <0%> (ø) ⬇️
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 36.81% <0%> (+0.46%) 69% <0%> (+1%) ⬆️
.../com/microsoft/sqlserver/jdbc/SQLServerSQLXML.java 12.69% <0%> (+0.79%) 9% <0%> (+1%) ⬆️
...va/com/microsoft/sqlserver/jdbc/SQLServerClob.java 33.59% <0%> (+1.18%) 4% <0%> (ø) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51d6c40...48aa95a. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.3.1 milestone Apr 27, 2019
peterbae
peterbae previously approved these changes Apr 30, 2019
View reviewed changes
rene-ye
rene-ye reviewed May 10, 2019
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/connection/TimeoutTest.java
rene-ye
rene-ye previously approved these changes May 10, 2019
View reviewed changes
@lilgreenbird lilgreenbird self-requested a review May 13, 2019 02:59
lilgreenbird
lilgreenbird previously approved these changes May 13, 2019
View reviewed changes
ulvii
ulvii reviewed May 15, 2019
View reviewed changes
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/connection/TimeoutTest.java Outdated
@cheenamalhotra cheenamalhotra dismissed stale reviews from lilgreenbird, rene-ye, and peterbae via 48aa95a May 15, 2019 16:40
@cheenamalhotra cheenamalhotra merged commit 20c0b81 into microsoft:dev May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@ulvii ulvii ulvii approved these changes

@peterbae peterbae peterbae approved these changes

@rene-ye rene-ye rene-ye left review comments

@lilgreenbird lilgreenbird lilgreenbird left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.3.1

Development

Successfully merging this pull request may close these issues.

[BUG]loginTimeout in URL not valid if DriverManager.setLoginTimeout

6 participants

@cheenamalhotra @codecov-io @rene-ye @lilgreenbird @ulvii @peterbae