Skip to content

Tests | Add tests for SQLServerConnection to improve code coverage#1047

Merged
lilgreenbird merged 15 commits intomicrosoft:devfrom
lilgreenbird:codecov2
May 11, 2019
Merged

Tests | Add tests for SQLServerConnection to improve code coverage#1047
lilgreenbird merged 15 commits intomicrosoft:devfrom
lilgreenbird:codecov2

Conversation

@lilgreenbird
Copy link
Copy Markdown
Contributor

@lilgreenbird lilgreenbird commented Apr 24, 2019

moved and renamed from connection/ConnectDriverTest to add more tests calling package private methods

peterbae
peterbae previously approved these changes Apr 26, 2019
@cheenamalhotra cheenamalhotra added this to the 7.3.1 milestone Apr 27, 2019
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/TimeoutTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/TimeoutTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java Outdated
@cheenamalhotra cheenamalhotra changed the title Add tests for SQLServerConnection to improve code coverage Tests | Add tests for SQLServerConnection to improve code coverage May 1, 2019
cheenamalhotra
cheenamalhotra previously approved these changes May 2, 2019
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/TimeoutTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java Outdated
Comment thread src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java Outdated
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 9, 2019

Codecov Report

Merging #1047 into dev will increase coverage by 0.18%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1047      +/-   ##
============================================
+ Coverage     52.79%   52.98%   +0.18%     
- Complexity     3130     3147      +17     
============================================
  Files           119      119              
  Lines         27941    27943       +2     
  Branches       4668     4668              
============================================
+ Hits          14752    14805      +53     
+ Misses        10963    10913      -50     
+ Partials       2226     2225       -1
Impacted Files Coverage Δ Complexity Δ
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 61.1% <ø> (+0.16%) 0 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 49.77% <0%> (+1%) 395 <0> (+10) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 68.36% <66.66%> (+1.12%) 169 <0> (+3) ⬆️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 43.95% <0%> (-3.3%) 15% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 67.41% <0%> (-0.21%) 64% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.59% <0%> (-0.12%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 44.37% <0%> (+0.19%) 330% <0%> (+3%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.94% <0%> (+1.07%) 112% <0%> (+1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e12d68...3d6871d. Read the comment docs.

peterbae
peterbae previously approved these changes May 9, 2019
@lilgreenbird lilgreenbird merged commit 2c965e2 into microsoft:dev May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants